Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider editor.codeActionsOnSave change #194119

Closed
jrieken opened this issue Sep 26, 2023 · 3 comments
Closed

Reconsider editor.codeActionsOnSave change #194119

jrieken opened this issue Sep 26, 2023 · 3 comments
Assignees
@Yoyokrazy @justschen
Labels
important Issue identified as high-priority

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2023

Testing #194077

It seems that the editor.codeActionsOnSave setting has changed its value type. There are a couple of issues with this

  • no automatic migration happened, e.g. all existing usages are now flagged as errors (see below). This isn't user-friendly and if we stick with this we should make sure to use our auto-migration logic. Check IConfigurationMigrationRegistry for this
  • I fail to understand the added value of this, the new values are as expressive as the old ones
  • For editor.codeActionsOnSave there is no IntelliSense of the value set
Screenshot 2023-09-26 at 11 42 20
@jrieken jrieken added the important Issue identified as high-priority label Sep 26, 2023
@gjsjohnmurray gjsjohnmurray mentioned this issue Sep 26, 2023
Open
@justschen
Copy link
Contributor

intellisense issue related to #161284

@justschen justschen mentioned this issue Sep 27, 2023
Merged
@jrieken
Copy link
Member Author

jrieken commented Sep 28, 2023

There is an unfortunate regression... It looks like the migration code that I have recommended isn't working great. I revert your changes and we need a path forward: either we get a fix for the migration or the setting is defined as boolean or string enum

@justschen
Copy link
Contributor

resolved in #194437. Migration to happen in next milestone with #194427 👍

@thernstig thernstig mentioned this issue Oct 26, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

@justschen justschen

Labels
important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrieken @Yoyokrazy @justschen