Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Notebook Diff Editor overview ruler #161861

Closed
2 tasks done
rebornix opened this issue Sep 26, 2022 · 3 comments
Closed
2 tasks done

Test: Notebook Diff Editor overview ruler #161861

rebornix opened this issue Sep 26, 2022 · 3 comments

Comments

@rebornix
Copy link
Member

rebornix commented Sep 26, 2022

Refs #146224

Authors: @rebornix

Complexity: 2

Create Issue


We now render changes decorations in the notebook diff editor, please test it's working as expected (like the text editor)

For example

  • Open a notebook
  • Go to Timeline view, click on any entry
  • A notebook diff editor opens, please check the decorations for diff changes are rendered at the right position
@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

+1 on all the issues @connor4312 found.
imho if we must lazily compute these decorations then the experience might be better without them, since right now I mostly find them confusing.

@rebornix
Copy link
Member Author

@connor4312 @isidorn thank you both for the thorough testing, the cell height being dynamic (in a virtualized list) is leading to the confusion (excluding the misalignment bugs). I'll consider having it disabled for the coming stable and having it back on in Insiders to give us time for polish.

@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2022

@rebornix makes sense, thanks 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants