Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook diff decorations have white horizontal lines rendered inside them #161918

Closed
isidorn opened this issue Sep 27, 2022 · 1 comment
Closed

Notebook diff decorations have white horizontal lines rendered inside them #161918

isidorn opened this issue Sep 27, 2022 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff verified Verification succeeded
Milestone
January 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

Testing #161861

Notice the white horizontal lines inside the diff decorations.
This looks like bad rendering 🐛

In the editor diff this does not happen.

Screenshot 2022-09-27 at 10 57 14
Screenshot 2022-09-27 at 10 57 18
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-diff labels Oct 21, 2022
@rebornix
Copy link
Member

Fixed via #170173. We should be using Math.round instead of Math.floor.

@rebornix rebornix reopened this Dec 28, 2022
rebornix added a commit that referenced this issue Dec 28, 2022
@rebornix
Fix #161918. Math.round for canvas position
af5b740
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Dec 28, 2022
@vscodenpa vscodenpa added this to the January 2023 milestone Dec 28, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2023
@bhavyaus bhavyaus added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
4 participants
@rebornix @isidorn @bhavyaus @vscodenpa