Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop coi doesn't work on windows #162141

Closed
jrieken opened this issue Sep 28, 2022 · 1 comment · Fixed by #162174
Closed

Desktop coi doesn't work on windows #162141

jrieken opened this issue Sep 28, 2022 · 1 comment · Fixed by #162174
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2022

Comments

@jrieken
Copy link
Member

jrieken commented Sep 28, 2022

  • run code-insiders --enable-coi
  • 🐛 the renderer is crossOriginIsolated
@jrieken jrieken self-assigned this Sep 28, 2022
@jrieken jrieken added this to the September 2022 milestone Sep 28, 2022
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Sep 28, 2022
@jrieken jrieken mentioned this issue Sep 28, 2022
Closed
15 tasks
@jrieken
Copy link
Member Author

jrieken commented Sep 28, 2022

paths are OS-paths, e.g backslash instead of fwdslash when checking this:

vscode/src/vs/platform/protocol/electron-main/protocolMainService.ts

Line 99 in 42a198b

if (path.endsWith('/workbench.html') || path.endsWith('/workbench-dev.html')) {

@jrieken jrieken mentioned this issue Sep 28, 2022
Merged
jrieken added a commit that referenced this issue Sep 28, 2022
@jrieken
check basename, not separator and name
23b5646 
fixes #162141
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 28, 2022
jrieken added a commit that referenced this issue Sep 28, 2022
@jrieken
check basename, not separator and name (#162174)
d31d71d 
fixes #162141
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 29, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

check basename, not separator and name microsoft/vscode
3 participants
@jrieken @rzhao271 @vscodenpa