Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore GPU rendering in the editor #162445

Closed
Tyriar opened this issue Sep 30, 2022 · 2 comments
Closed

Explore GPU rendering in the editor #162445

Tyriar opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality perf

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 30, 2022

I did an exploration recently into using webgl in the editor by forking/integrating xterm.js' renderer into monaco. The results look very promising, here is a summary:

  • There are big wins to FPS/scrolling performance and overall smoothness of the application, especially for average/old hardware.
  • We could introduce an experimental renderer and progressively "upgrade" parts of Monaco as needed
  • Regardless of whether we pursue GPU acceleration, we should fine tune input latency performance Optimize editor for input latency #161622

Exploration branch: https://github.com/microsoft/vscode/tree/tyriar/webgl_monaco

@Tyriar Tyriar added feature-request Request for new features or functionality editor-rendering Editor rendering issues labels Sep 30, 2022
@Tyriar Tyriar added this to the On Deck milestone Sep 30, 2022
@Tyriar Tyriar self-assigned this Sep 30, 2022
@Tyriar Tyriar added the perf label Dec 13, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Dec 13, 2023

Closing as the exploration was done, we may or may not do this in the future. The main concern is it's a lot of effort to create and maintain given my experience doing the terminal renderer. Especially since monaco relies on a lot of DOM functionality and accessibility is a big headache when using canvas.

@Tyriar Tyriar closed this as completed Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 8, 2024

New issue for this feature: #221145

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality perf
Projects
None yet
Development

No branches or pull requests

2 participants