Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I find that in the click panel whatever you click mouse left or rigth it will confirm click #163247

Closed
IOLOII opened this issue Oct 11, 2022 · 5 comments · Fixed by #165177
Closed
Assignees
Labels
menus Menu items and widget issues verified Verification succeeded
Milestone

Comments

@IOLOII
Copy link

IOLOII commented Oct 11, 2022

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • 版本: 1.72.0 (system setup)
    提交: 64bbfbf
    日期: 2022-10-04T23:20:39.912Z
    Electron: 19.0.17
    Chromium: 102.0.5005.167
    Node.js: 16.14.2
    V8: 10.2.154.15-electron.0
    OS: Windows_NT x64 10.0.22000
  • OS Version:
  • 版本 Windows 11 家庭中文版
    版本 21H2
    安装日期 ‎2021/‎10/‎21
    操作系统版本 22000.856
    体验 Windows 功能体验包 1000.22000.856.0

Steps to Reproduce:

  1. mouse right button click the side menus : to open the menus panel (Please note that it's right mouse button)
  2. then mouse right button click panel with one casual click , it will checked (clicked) the under menu which mouse overed

In my common sense like this UI action , it may be a cancel action isn't right ?

Here is record video
https://user-images.githubusercontent.com/34856171/194986988-8df4b174-6eca-4a0b-b794-3fc093373757.mp4

And also find that sometime it will one right click and quick hide side menus, in the upload video it happend in the last time and one times, so I try to find why? Because right click to open menus panel and don't quickly release the mouse right button , it may be sometimes trigger this action. In a nutshell : after click side menu and release rigth mouse button later ,the right mouse button has confirm function. so this happend.


oh , I have another question : I want to know what's this terminal and what's it theme, It looks so cool! please
vscode update illustration
vscode update illustration
image
I guess may be zsh, but couldn't find the theme config, help me thanks, I really want use.

@IOLOII IOLOII changed the title I find that in the click panel whaterer you click mouse left or rigth it will confirm click I find that in the click panel whatever you click mouse left or rigth it will confirm click Oct 11, 2022
@sbatten
Copy link
Member

sbatten commented Nov 1, 2022

@IOLOII I will try to outline the intended behavior and please let me know if this does not match your experience.

  1. Right click in the activity bar opens the activity bar's context menu (this menu ends with "Hide Activity Bar"
  2. Right click in a menu performs the same action as left click.

Where I see a bug, the context menu is appearing on mouse down, not mouse up when the right click happens over the global actions of the activity bar.

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues labels Nov 1, 2022
@sbatten sbatten added this to the November 2022 milestone Nov 1, 2022
@meganrogge
Copy link
Contributor

@IOLOII my terminal is using the Dark+ (default) theme and oh-my-zsh

@sbatten
Copy link
Member

sbatten commented Nov 1, 2022

To Verify The Fix:

  1. Right click the Accounts Icon, Settings Gear, and Profiles Icons
  2. Ensure that the behavior for the context menu matches that of a right of anywhere else in the activity bar

On Windows, this means the context menu appears at the location of the mouse click and on mouse UP.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 1, 2022
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@connor4312
Copy link
Member

connor4312 commented Nov 30, 2022

On web (PWA), right clicking on the manage gear does not work. The context menu flashes up and immediately closes

Kapture 2022-11-30 at 09 53 03

Similarly, right clicking the account menu has the flash, but then the account menu instead of the ordinary context menu appears:

Kapture 2022-11-30 at 09 50 49

Sometimes these flashes are so fast as to be invisible, but other times you can see them, as in the recordings.

@connor4312 connor4312 reopened this Nov 30, 2022
@connor4312 connor4312 added verification-found Issue verification failed and removed bug Issue identified by VS Code Team member as probable bug labels Nov 30, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Nov 30, 2022
@connor4312
Copy link
Member

Actually, this works on desktop. It seems like context menus are broken in PWA in general 😬

@connor4312 connor4312 removed the verification-found Issue verification failed label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants