Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Task Status is not correct #163393

Closed
supermanmsc opened this issue Oct 12, 2022 · 2 comments · Fixed by #163952
Closed

Shell Task Status is not correct #163393

supermanmsc opened this issue Oct 12, 2022 · 2 comments · Fixed by #163952
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone

Comments

@supermanmsc
Copy link

Does this issue occur when all extensions are disabled?: Yes/No
YES

  • VS Code Version:
  • Version: 1.72.1
    Commit: 129500e
    Date: 2022-10-10T17:23:16.506Z
    Electron: 19.0.17
    Chromium: 102.0.5005.167
    Node.js: 16.14.2
    V8: 10.2.154.15-electron.0
    OS: Darwin arm64 21.6.0
    Sandboxed: No
  • OS Version:

图片

Steps to Reproduce:

  1. make a shell task to run a shell script file , set pretention as follow:
    "presentation": {
    "echo": true,
    "reveal": "always",
    "focus": false,
    "panel": "new",
    "showReuseMessage": true,
    "clear": false
    },
  2. use cmd+shift +B run this task once, then ,the terminal pannel will display run result status as ok
  3. use cmd+shift+b run this task twice , then ,the terminal pannel will display two termianl window, and the bug is: the first one and the second one all display the running icon !! when the second task display run stauts , the first termianl display running icon all the time.
@joyceerhl joyceerhl assigned meganrogge and unassigned joyceerhl Oct 13, 2022
@meganrogge meganrogge added this to the Backlog milestone Oct 13, 2022
mustard-mh added a commit to mustard-mh/vscode that referenced this issue Oct 14, 2022
mustard-mh added a commit to mustard-mh/vscode that referenced this issue Oct 14, 2022
@jeanp413
Copy link
Contributor

@mustard-mh is working on a fix for this 🙂

mustard-mh added a commit to mustard-mh/vscode that referenced this issue Oct 15, 2022
mustard-mh added a commit to mustard-mh/vscode that referenced this issue Oct 18, 2022
Co-authored-by: jeanp413 <jeanp413@hotmail.com>
@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 18, 2022

We created a PR #163952 to fix this.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug and removed confirmation-pending labels Oct 18, 2022
@meganrogge meganrogge modified the milestones: Backlog, November 2022 Nov 2, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 3, 2022
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants