Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates still applied despite policy setting #163418

Closed
madig opened this issue Oct 12, 2022 · 41 comments · Fixed by #171499
Closed

Updates still applied despite policy setting #163418

madig opened this issue Oct 12, 2022 · 41 comments · Fixed by #171499
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verification-steps-needed Steps to verify are needed for verification verified Verification succeeded windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Milestone

Comments

@madig
Copy link

madig commented Oct 12, 2022

Type: Bug

  1. Set update.mode = none (e.g. via group policy)
  2. Still get the "1" badge on the settings icon in the lower left corner telling you about an update

The "Main" log after startup shows:

[2022-10-12 10:54:29.870] [main] [info] update#setState idle
[2022-10-12 10:54:30.677] [main] [info] Starting extension host with pid 17568 (fork() took 15 ms).
[2022-10-12 10:54:59.877] [main] [info] update#setState checking for updates
[2022-10-12 10:54:59.881] [main] [info] update#setState downloading
[2022-10-12 10:54:59.883] [main] [info] update#setState downloaded

Additionally disabling update.enableWindowsBackgroundUpdates instead makes an obnoxious notifcation pop up on every start/window reload.

VS Code version: Code 1.72.0 (64bbfbf, 2022-10-04T23:20:39.912Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No

System Info
Item Value
CPUs AMD Ryzen 7 5700G with Radeon Graphics (16 x 3793)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) undefined
Memory (System) 27.88GB (15.65GB free)
Process Argv --crash-reporter-id bf85a791-c1e6-499d-9010-2c54f6076653
Screen Reader no
VM 0%
Extensions (18)
Extension Author (truncated) Version
EditorConfig Edi 0.16.4
gitlab-workflow Git 3.53.0
python ms- 2022.16.0
vscode-pylance ms- 2022.10.10
jupyter ms- 2022.9.1202862440
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.10
vscode-jupyter-cell-tags ms- 0.1.6
vscode-jupyter-slideshow ms- 0.1.5
remote-ssh ms- 0.90.1
remote-ssh-edit ms- 0.84.0
remote-wsl ms- 0.72.0
cpptools ms- 1.12.4
hexeditor ms- 1.9.9
remote-repositories ms- 0.22.0
rust-analyzer rus 0.3.1238
rewrap stk 1.16.3
vscode-lldb vad 1.8.1

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
pyindex848:30577860
fc301958:30573243

@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@joaomoreno
Copy link
Member

Set update.mode = none (e.g. via group policy)

How did you do this, exactly?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Oct 12, 2022
@joaomoreno joaomoreno changed the title Update notifications despite update.mode = none Updates still applied despite policy setting Oct 12, 2022
@TreeBranches
Copy link

TreeBranches commented Oct 17, 2022

@joaomoreno We obtained the VSCode ADML from the VSCode 1.72.2 ZIP file (policies folder) and roll out the GPO to all computers in our domain, which is how @madig gets the configuration.

Neither the Install Updates (1) badge nor the Update notification popup should be appearing when "Disable Updates" is set (as it shouldn't be checking for them in the first place), yet it continues to do so, despite the configuration applying (as seen in his config file).

image

@joaomoreno
Copy link
Member

I can't reproduce. When I set it to Disable updates. this is how the setting appears in the settings editor:

image

Are you setting it at the user or machine level?

@madig
Copy link
Author

madig commented Oct 17, 2022

I don't have the setting in my user's settings.json, if that's what you mean.

@joaomoreno
Copy link
Member

joaomoreno commented Oct 17, 2022

Can you show me the settings editor focused on that setting? With the policy applied, that is.

My question was regarding the policy: whether it's set at the user or machine level.

@TreeBranches
Copy link

I can't reproduce. When I set it to Disable updates. this is how the setting appears in the settings editor:

image

Are you setting it at the user or machine level?

That is also how the setting appears on our editor (the "None" setting).

Policies are deployed as a computer settings, as we're using the System installer (MSI), and want it to apply for all users.

@joaomoreno
Copy link
Member

joaomoreno commented Oct 17, 2022

Do you have the This setting is managed by your organization message?

@madig
Copy link
Author

madig commented Oct 17, 2022

Yes: grafik

@joaomoreno
Copy link
Member

OK. If you see that, it means it's working. If you restart VS Code, does the Main log still show the same update service output?

@ptdalen
Copy link

ptdalen commented Oct 24, 2022

We are having the same behavior. The only thing I can think of is that our enterprise installs vscode to D:\Program Files (x86)\Microsoft VS Code\ We are running 1.71.0.

image

Here is a log output showing that vscode is checking for updates even though it's set to none
image

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-os-integration Native OS integration issues and removed info-needed Issue requires more information from poster labels Oct 25, 2022
@joaomoreno joaomoreno added this to the November 2022 milestone Oct 25, 2022
@joaomoreno joaomoreno added the windows VS Code on Windows issues label Oct 25, 2022
@joaomoreno
Copy link
Member

@sandy081 Need your eyes here. Look at the screenshot above:

  • The settings editor shows that we're reading the policy correctly from Windows, since the settings editor shows that UI.
  • But the update service (main process) doesn't seem to read the same value at startup.

Do we maybe have a race condition?

@sandy081
Copy link
Member

Only possible scenario I can think of is following

If the native policy service is not initialising when it is asked to initialise

protected async initializePolicies(policyDefinitions: IStringDictionary<PolicyDefinition>): Promise<void> {

Do you think if there is any caching involved while reading the policies?

Is it helpful to add log (debug) statement after initialising policies by the policy service?

@TreeBranches
Copy link

TreeBranches commented Oct 25, 2022

Either myself or @madig can provide any logs you require.

In case relevant, we also use the 64bit System Wide installer (.MSI) (.EXE) in our org as opposed to the User Install in AppData, but at its default install location C:\Program Files\Microsoft VS Code\Code.exe

@joaomoreno
Copy link
Member

@TreeBranches We don't distribute an .MSI package ourselves. Can you clarify if that is really an .MSI or an .EXE?

@TreeBranches
Copy link

TreeBranches commented Nov 1, 2022

@TreeBranches We don't distribute an .MSI package ourselves. Can you clarify if that is really an .MSI or an .EXE?

@joaomoreno My mistake, it is the EXE provided in https://code.visualstudio.com/#alt-downloads - 64bit System Wide Installer.

Deployed with the following switches;

VSCodeSetup-x64-1.72.2.exe /LOADINF=VSCode.inf /VERYSILENT /NORESTART /RESTARTEXITCODE=0 /NOCLOSEAPPLICATIONS

VSCode.inf contains the following data;

[Setup]
Lang=English
Dir=C:\Program Files\Microsoft VS Code
Group=Visual Studio Code
NoIcons=0
Tasks=addcontextmenufiles,addcontextmenufolders,associatewithfiles,addtopath

@joaomoreno
Copy link
Member

I've added trace logging to the NativePolicyService which should help us get more visibility on this.

@TreeBranches, @ptdalen, @madig Could you install VS Code Insiders tomorrow, then run Developer: Set Log Level..., set the logging level to Trace and open the Main log in the Output pane and show me whatever logs you might have related to NativePolicyService?

joaomoreno added a commit that referenced this issue Nov 16, 2022
@joaomoreno joaomoreno added this to the January 2023 milestone Dec 9, 2022
@joaomoreno
Copy link
Member

@madig, @sandy081 has pushed a few more log statements here. Can you give this a try again on the latest insiders and send us the full logs? Thank you!

@joaomoreno
Copy link
Member

Let us know, @madig. Also @TreeBranches, if you're still around! 🙏

@madig
Copy link
Author

madig commented Dec 14, 2022

Oops, sorry, this fell off my todo list. Newest Insiders from right now, all lines with policy or update in it:

2022-12-14 12:07:14.924 [trace] PolicyConfiguration#initialize
2022-12-14 12:07:14.924 [trace] PolicyConfiguration#updatePolicyDefinitions ["http.proxy","http.proxyStrictSSL","http.proxyAuthorization","http.proxySupport","http.systemCertificates","telemetry.telemetryLevel","telemetry.enableTelemetry","update.mode","update.channel","update.enableWindowsBackgroundUpdates","update.showReleaseNotes"]
2022-12-14 12:07:14.924 [trace] NativePolicyService#_updatePolicyDefinitions - Found 1 policy definitions
2022-12-14 12:07:14.925 [trace] NativePolicyService#_onDidPolicyChange - Updated policy values: {"UpdateMode":"none"}
2022-12-14 12:07:14.925 [trace] PolicyConfiguration#update ["update.mode"]
2022-12-14 12:07:14.925 [trace] PolicyConfiguration#changed [["update.mode","none"]]
2022-12-14 12:07:14.925 [debug] args: {"_":[],"diff":false,"merge":false,"add":false,"goto":false,"new-window":false,"reuse-window":false,"wait":false,"help":false,"list-extensions":false,"show-versions":false,"pre-release":false,"version":false,"verbose":false,"log":["trace"],"status":false,"prof-startup":false,"no-cached-data":false,"prof-v8-extensions":false,"disable-extensions":false,"disable-gpu":false,"ms-enable-electron-run-as-node":false,"telemetry":false,"debugRenderer":false,"enable-smoke-test-driver":false,"logExtensionHostCommunication":false,"skip-release-notes":false,"skip-welcome":false,"disable-telemetry":false,"disable-updates":false,"disable-keytar":false,"disable-workspace-trust":false,"disable-crash-reporter":false,"crash-reporter-id":"c15f7469-5eb3-4fcb-af09-3f2a3f7fdc86","skip-add-to-recently-opened":false,"unity-launch":false,"open-url":false,"file-write":false,"file-chmod":false,"force":false,"do-not-sync":false,"trace":false,"force-user-env":false,"force-disable-user-env":false,"open-devtools":false,"__enable-file-policy":false,"enable-coi":false,"no-proxy-server":false,"no-sandbox":false,"nolazy":false,"force-renderer-accessibility":false,"ignore-certificate-errors":false,"allow-insecure-localhost":false,"disable-dev-shm-usage":false,"profile-temp":false,"logsPath":"C:\\Users\\nikolaus.waxweiler\\AppData\\Roaming\\Code - Insiders\\logs\\20221214T120714"}
2022-12-14 12:07:15.022 [info] update#setState idle
2022-12-14 12:07:15.904 [trace] RequestService#request (node) - begin https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b
2022-12-14 12:07:16.059 [trace] RequestService#request (node) - success https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b

Full logs:

2022-12-14 12:07:14.924 [trace] PolicyConfiguration#initialize
2022-12-14 12:07:14.924 [trace] PolicyConfiguration#updatePolicyDefinitions ["http.proxy","http.proxyStrictSSL","http.proxyAuthorization","http.proxySupport","http.systemCertificates","telemetry.telemetryLevel","telemetry.enableTelemetry","update.mode","update.channel","update.enableWindowsBackgroundUpdates","update.showReleaseNotes"]
2022-12-14 12:07:14.924 [trace] NativePolicyService#_updatePolicyDefinitions - Found 1 policy definitions
2022-12-14 12:07:14.924 [trace] [File Watcher (node.js)] Request to start watching: c:\Users\...\AppData\Roaming\Code - Insiders\User (excludes: <none>, includes: <all>),c:\Users\...\AppData\Roaming\Code - Insiders\User\settings.json (excludes: <none>, includes: <all>)
2022-12-14 12:07:14.925 [trace] NativePolicyService#_onDidPolicyChange - Updated policy values: {"UpdateMode":"none"}
2022-12-14 12:07:14.925 [trace] PolicyConfiguration#update ["update.mode"]
2022-12-14 12:07:14.925 [trace] PolicyConfiguration#changed [["update.mode","none"]]
2022-12-14 12:07:14.925 [debug] Starting VS Code
2022-12-14 12:07:14.925 [debug] from: c:\Users\...\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app
2022-12-14 12:07:14.925 [debug] args: {"_":[],"diff":false,"merge":false,"add":false,"goto":false,"new-window":false,"reuse-window":false,"wait":false,"help":false,"list-extensions":false,"show-versions":false,"pre-release":false,"version":false,"verbose":false,"log":["trace"],"status":false,"prof-startup":false,"no-cached-data":false,"prof-v8-extensions":false,"disable-extensions":false,"disable-gpu":false,"ms-enable-electron-run-as-node":false,"telemetry":false,"debugRenderer":false,"enable-smoke-test-driver":false,"logExtensionHostCommunication":false,"skip-release-notes":false,"skip-welcome":false,"disable-telemetry":false,"disable-updates":false,"disable-keytar":false,"disable-workspace-trust":false,"disable-crash-reporter":false,"crash-reporter-id":"c15f7469-5eb3-4fcb-af09-3f2a3f7fdc86","skip-add-to-recently-opened":false,"unity-launch":false,"open-url":false,"file-write":false,"file-chmod":false,"force":false,"do-not-sync":false,"trace":false,"force-user-env":false,"force-disable-user-env":false,"open-devtools":false,"__enable-file-policy":false,"enable-coi":false,"no-proxy-server":false,"no-sandbox":false,"nolazy":false,"force-renderer-accessibility":false,"ignore-certificate-errors":false,"allow-insecure-localhost":false,"disable-dev-shm-usage":false,"profile-temp":false,"logsPath":"C:\\Users\\...\\AppData\\Roaming\\Code - Insiders\\logs\\20221214T120714"}
2022-12-14 12:07:14.925 [trace] Resolving machine identifier...
2022-12-14 12:07:14.925 [trace] Resolved machine identifier: 4728a78a2ae5bca24b3af13388ef14bbee3b6eff45bbbe235d90dabd6d81630a
2022-12-14 12:07:14.925 [trace] Main->SharedProcess#connect
2022-12-14 12:07:14.927 [trace] StorageMainService: creating application storage
2022-12-14 12:07:14.928 [trace] lifecycle (main): phase changed (value: 2)
2022-12-14 12:07:14.929 [trace] windowsManager#open
2022-12-14 12:07:14.930 [trace] windowsManager#open pathsToOpen [{"backupPath":"C:\\Users\\...\\AppData\\Roaming\\Code - Insiders\\Backups\\1671019630005"}]
2022-12-14 12:07:14.931 [trace] windowsManager#doOpenEmpty {"restore":true,"forceNewWindow":true}
2022-12-14 12:07:14.931 [trace] IPC Object URL: Registered new channel vscode:75a74a8c-14f5-4bc5-a6ba-641834cde980.
2022-12-14 12:07:14.931 [trace] window#validateWindowState: validating window state on 1 display(s) {"mode":0,"x":0,"y":288,"width":1412,"height":1004}
2022-12-14 12:07:14.931 [trace] window#validateWindowState: 1 monitor working area {"x":0,"y":0,"width":2560,"height":1392}
2022-12-14 12:07:14.932 [trace] window#ctor: using window state {"mode":0,"x":0,"y":288,"width":1412,"height":1004}
2022-12-14 12:07:14.974 [trace] window#load: attempt to load window (id: 1)
2022-12-14 12:07:15.002 [trace] windowsManager#open used window count 1 (workspacesToOpen: 0, foldersToOpen: 0, emptyToRestore: 1, emptyToOpen: 0)
2022-12-14 12:07:15.002 [trace] lifecycle (main): phase changed (value: 3)
2022-12-14 12:07:15.013 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:15.022 [info] update#setState idle
2022-12-14 12:07:15.052 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\AppData\Roaming\Code - Insiders\User'
2022-12-14 12:07:15.055 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\AppData\Roaming\Code - Insiders\User\settings.json'
2022-12-14 12:07:15.061 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:15.310 [trace] StorageMainService: creating workspace storage (1671019630005)
2022-12-14 12:07:15.537 [trace] window#load: window reported ready (id: 1)
2022-12-14 12:07:15.582 [trace] SharedProcess: on vscode:createSharedProcessMessageChannel
2022-12-14 12:07:15.583 [trace] IPC Object URL: Registered new channel vscode:8bddbe16-7943-42fd-905f-a3c29d4011c0.
2022-12-14 12:07:15.658 [info] UtilityProcess<1>: Creating new...
2022-12-14 12:07:15.672 [info] UtilityProcess<1>: received spawn event.
2022-12-14 12:07:15.749 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:15.803 [trace] Getting password from keytar: vscode-insiders.login account
2022-12-14 12:07:15.810 [trace] Did not get a password from keytar for account: account
2022-12-14 12:07:15.830 [trace] SharedProcess: IPC ready
2022-12-14 12:07:15.837 [trace] Main->SharedProcess#connect: connection established
2022-12-14 12:07:15.843 [trace] [File Watcher (node.js)] Request to start watching: c:\Users\...\AppData\Roaming\Code - Insiders\User (excludes: <none>, includes: <all>),c:\Users\...\AppData\Roaming\Code - Insiders\User\settings.json (excludes: <none>, includes: <all>)
2022-12-14 12:07:15.849 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\AppData\Roaming\Code - Insiders\User'
2022-12-14 12:07:15.849 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\AppData\Roaming\Code - Insiders\User\settings.json'
2022-12-14 12:07:15.904 [trace] RequestService#request (node) - begin https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b
2022-12-14 12:07:15.904 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:15.922 [trace] SharedProcess: Overall ready
2022-12-14 12:07:15.934 [trace] RequestService#request (node) - begin https://az764295.vo.msecnd.net/extensions/marketplace.json
2022-12-14 12:07:15.935 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:15.949 [trace] [File Watcher (node.js)] Request to start watching: c:\Users\...\.vscode-insiders\extensions (excludes: <none>, includes: <all>),c:\Users\...\.vscode-insiders\extensions\extensions.json (excludes: <none>, includes: <all>)
2022-12-14 12:07:15.952 [trace] RequestService#request (node) - success https://az764295.vo.msecnd.net/extensions/marketplace.json
2022-12-14 12:07:15.955 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\.vscode-insiders\extensions'
2022-12-14 12:07:15.957 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\.vscode-insiders\extensions\extensions.json'
2022-12-14 12:07:16.059 [trace] RequestService#request (node) - success https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b
2022-12-14 12:07:16.106 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication microsoft.login.keylist
2022-12-14 12:07:16.106 [trace] Got password from keytar for account: microsoft.login.keylist
2022-12-14 12:07:16.171 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication XXX
2022-12-14 12:07:16.172 [trace] Got password from keytar for account: XXX
2022-12-14 12:07:16.229 [trace] SharedProcess: onWorkerConnection {"process":{"moduleId":"vs/platform/files/node/watcher/watcherMain","type":"fileWatcher"},"reply":{"windowId":1,"channel":"vscode:createSharedProcessWorkerMessageChannelResult","nonce":"625fac27-3fc3-43e1-9ed9-a7cea090350a"}}
2022-12-14 12:07:16.692 [trace] Setting password using keytar: vscode-insidersvscode.microsoft-authentication XXX
2022-12-14 12:07:16.696 [trace] Got password from keytar for account: XXX
2022-12-14 12:07:16.722 [trace] Getting password from keytar: vscode-insidersvscode.github-authentication github.auth
2022-12-14 12:07:16.727 [trace] Did not get a password from keytar for account: github.auth
2022-12-14 12:07:16.732 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication XXX
2022-12-14 12:07:16.733 [trace] Got password from keytar for account: XXX
2022-12-14 12:07:16.735 [trace] RequestService#request (node) - begin https://vscode-sync-insiders.trafficmanager.net/v1/manifest
2022-12-14 12:07:16.735 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:16.855 [trace] RequestService#request (node) - success https://vscode-sync-insiders.trafficmanager.net/v1/manifest
2022-12-14 12:07:16.857 [trace] RequestService#request (node) - begin https://vscode-sync-insiders.trafficmanager.net/v1/resource/machines/latest
2022-12-14 12:07:16.857 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:16.892 [trace] RequestService#request (node) - success https://vscode-sync-insiders.trafficmanager.net/v1/resource/machines/latest
2022-12-14 12:07:16.896 [trace] [File Watcher (node.js)] Request to start watching: c:\Users\...\AppData\Roaming\Code - Insiders\User\snippets (excludes: <none>, includes: <all>)
2022-12-14 12:07:16.897 [debug] ProfileStorageChangesListenerChannel#registerStorageChangeListeners
2022-12-14 12:07:16.902 [trace] [File Watcher (node.js)] Started watching: 'c:\Users\...\AppData\Roaming\Code - Insiders\User\snippets'
2022-12-14 12:07:16.952 [trace] RequestService#request (node) - begin https://vscode-sync-insiders.trafficmanager.net/v1/resource/globalState
2022-12-14 12:07:16.952 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:17.011 [trace] RequestService#request (node) - success https://vscode-sync-insiders.trafficmanager.net/v1/resource/globalState
2022-12-14 12:07:17.519 [trace] lifecycle (main): phase changed (value: 4)
2022-12-14 12:07:45.037 [trace] update#checkForUpdates, state =  idle
2022-12-14 12:07:45.037 [info] update#setState checking for updates
2022-12-14 12:07:45.038 [trace] RequestService#request (node) - begin https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b
2022-12-14 12:07:45.038 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:07:45.053 [trace] RequestService#request (node) - success https://update.code.visualstudio.com/api/update/win32-x64-user/insider/11238faea62d570d77afe6edfe05c8b732c44a2b
2022-12-14 12:07:45.053 [info] update#setState idle
2022-12-14 12:08:59.385 [trace] RequestService#request (node) - begin https://vscode-sync-insiders.trafficmanager.net/v1/manifest
2022-12-14 12:08:59.385 [trace] resolveShellEnv(): skipped (Windows)
2022-12-14 12:08:59.409 [trace] RequestService#request (node) - success https://vscode-sync-insiders.trafficmanager.net/v1/manifest

@joaomoreno
Copy link
Member

@madig @TreeBranches We think we found the issue. The update.mode setting used to be called update.channel. We think you might still have a value for update.channel, is that true? If you remove that value, is the issue fixed?

@madig
Copy link
Author

madig commented Dec 14, 2022

Where is that value stored? There's nothing in my settings.json.

@SnowJuli
Copy link

SnowJuli commented Jan 4, 2023

@joaomoreno @madig Any updates on this?

@madig
Copy link
Author

madig commented Jan 4, 2023

(I don't know where the setting is, so I haven't checked further)

@TreeBranches
Copy link

Hi @joaomoreno . @madig is a user in our domain and so any logs submits by them will be the same as anything I would produce. I am keeping an eye on the thread though in case changes are made (either to VSCode or the ADMX file) and will contribute if required.

@SnowJuli
Copy link

SnowJuli commented Jan 4, 2023

(I don't know where the setting is, so I haven't checked further)

you can check the settings.json by calling it from the Command Palette (Strg + Shift + P -> Search for "Open Settings (JSON)")

@SnowJuli
Copy link

SnowJuli commented Jan 4, 2023

Side note for @joaomoreno

I tested it by using just a registry entry but this didnt work at all. It showed that it is managed by my organisation but it still auto updated.

@madig
Copy link
Author

madig commented Jan 4, 2023

There is no update.* setting my my JSON config.

joaomoreno added a commit that referenced this issue Jan 17, 2023
@joaomoreno
Copy link
Member

Sorry for the delay here. @sandy081 and I found the issue! Many thanks for your patience. Fix will come in the next release.

joaomoreno added a commit that referenced this issue Jan 17, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 17, 2023
@lramos15 lramos15 added the author-verification-requested Issues potentially verifiable by issue author label Jan 26, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@madig, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 07d6f5b of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@alexr00 alexr00 added the ~verification-steps-needed Steps to verify are needed (with bot comment) label Jan 27, 2023
@vscodenpa
Copy link

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@vscodenpa vscodenpa added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels Jan 27, 2023
@SnowJuli
Copy link

Not OP, but I would be glad to verify it on Monday, if Madig doesn't respond in Time.

@madig
Copy link
Author

madig commented Jan 27, 2023

I now see

[info] update#ctor - updates are disabled by user preference

in the main log on startup. So I guess /verified.

@joaomoreno joaomoreno added the verified Verification succeeded label Jan 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verification-steps-needed Steps to verify are needed for verification verified Verification succeeded windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants