-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates still applied despite policy setting #163418
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
How did you do this, exactly? |
update.mode = none
@joaomoreno We obtained the VSCode ADML from the VSCode 1.72.2 ZIP file (policies folder) and roll out the GPO to all computers in our domain, which is how @madig gets the configuration. Neither the Install Updates (1) badge nor the Update notification popup should be appearing when "Disable Updates" is set (as it shouldn't be checking for them in the first place), yet it continues to do so, despite the configuration applying (as seen in his config file). |
I don't have the setting in my user's settings.json, if that's what you mean. |
Can you show me the settings editor focused on that setting? With the policy applied, that is. My question was regarding the policy: whether it's set at the user or machine level. |
That is also how the setting appears on our editor (the "None" setting). Policies are deployed as a computer settings, as we're using the System installer (MSI), and want it to apply for all users. |
Do you have the |
OK. If you see that, it means it's working. If you restart VS Code, does the Main log still show the same update service output? |
@sandy081 Need your eyes here. Look at the screenshot above:
Do we maybe have a race condition? |
Only possible scenario I can think of is following If the native policy service is not initialising when it is asked to initialise
Do you think if there is any caching involved while reading the policies? Is it helpful to add log (debug) statement after initialising policies by the policy service? |
Either myself or @madig can provide any logs you require. In case relevant, we also use the 64bit System Wide installer |
@TreeBranches We don't distribute an .MSI package ourselves. Can you clarify if that is really an .MSI or an .EXE? |
@joaomoreno My mistake, it is the EXE provided in https://code.visualstudio.com/#alt-downloads - 64bit System Wide Installer. Deployed with the following switches;
VSCode.inf contains the following data;
|
I've added trace logging to the NativePolicyService which should help us get more visibility on this. @TreeBranches, @ptdalen, @madig Could you install VS Code Insiders tomorrow, then run |
Let us know, @madig. Also @TreeBranches, if you're still around! 🙏 |
Oops, sorry, this fell off my todo list. Newest Insiders from right now, all lines with policy or update in it:
Full logs:
|
@madig @TreeBranches We think we found the issue. The |
Where is that value stored? There's nothing in my settings.json. |
@joaomoreno @madig Any updates on this? |
(I don't know where the setting is, so I haven't checked further) |
Hi @joaomoreno . @madig is a user in our domain and so any logs submits by them will be the same as anything I would produce. I am keeping an eye on the thread though in case changes are made (either to VSCode or the ADMX file) and will contribute if required. |
you can check the settings.json by calling it from the Command Palette (Strg + Shift + P -> Search for "Open Settings (JSON)") |
Side note for @joaomoreno I tested it by using just a registry entry but this didnt work at all. It showed that it is managed by my organisation but it still auto updated. |
There is no |
Sorry for the delay here. @sandy081 and I found the issue! Many thanks for your patience. Fix will come in the next release. |
This bug has been fixed in the latest release of VS Code Insiders! @madig, you can help us out by commenting If things still don't seem right, please ensure you're on version 07d6f5b of Insiders (today's or later - you can use Happy Coding! |
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue. |
Not OP, but I would be glad to verify it on Monday, if Madig doesn't respond in Time. |
I now see
in the main log on startup. So I guess /verified. |
Type: Bug
update.mode = none
(e.g. via group policy)The "Main" log after startup shows:
Additionally disabling
update.enableWindowsBackgroundUpdates
instead makes an obnoxious notifcation pop up on every start/window reload.VS Code version: Code 1.72.0 (64bbfbf, 2022-10-04T23:20:39.912Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Extensions (18)
(1 theme extensions excluded)
A/B Experiments
The text was updated successfully, but these errors were encountered: