Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folder rename does not result in updated path #164562

Closed
weinand opened this issue Oct 25, 2022 · 3 comments · Fixed by #164752 or #164829
Closed

folder rename does not result in updated path #164562

weinand opened this issue Oct 25, 2022 · 3 comments · Fixed by #164752 or #164829
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Milestone
October 2022

Comments

@weinand
Copy link
Contributor

weinand commented Oct 25, 2022 •
edited
Loading

Testing #164522

Given this setup:

CleanShot 2022-10-25 at 12 31 35@2x

renaming folder "foo" to "bar" does trigger the prompt but the path "/foo/file_2.md" is not updated (and gets broken).
@mjbvz mjbvz added this to the October 2022 milestone Oct 25, 2022
@mjbvz mjbvz added markdown Markdown support issues bug Issue identified by VS Code Team member as probable bug labels Oct 25, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 26, 2022
@mjbvz
Fix markdown server not updating documents properly on folder rename
9ea656c 
Fixes microsoft#164562
@mjbvz mjbvz mentioned this issue Oct 26, 2022
Merged
mjbvz added a commit that referenced this issue Oct 26, 2022
@mjbvz
Fix markdown server not updating documents properly on folder rename (#…
5f87632 
…164752)

Fixes #164562
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
@mjbvz @formigoni
Fix markdown server not updating documents properly on folder rename (m…
66da5c6 
…icrosoft#164752)

Fixes microsoft#164562
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2022
@joyceerhl
Copy link
Contributor

Still repros for me:
image

@joyceerhl joyceerhl added verification-found Issue verification failed and removed verified Verification succeeded labels Oct 27, 2022
@joyceerhl joyceerhl reopened this Oct 27, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Oct 27, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 27, 2022
@mjbvz
Fix markdown document deleting
08c0315 
Fixes microsoft#164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not
@mjbvz mjbvz mentioned this issue Oct 27, 2022
Merged
mjbvz added a commit that referenced this issue Oct 27, 2022
@mjbvz
Fix markdown document deleting (#164829)
3544aab 
Fixes #164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 27, 2022
@andreamah andreamah added verified Verification succeeded and removed verified Verification succeeded labels Oct 28, 2022
@andreamah
Copy link
Contributor

Still repros for me

Image from Gyazo

@andreamah andreamah reopened this Oct 28, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Oct 28, 2022
@mjbvz mjbvz modified the milestones: October 2022, November 2022 Oct 28, 2022
@mjbvz mjbvz mentioned this issue Oct 28, 2022
Merged
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 28, 2022

Ugh this bug :/ I'm marking it as a candidate because I'm pretty sure the root cause (#164942) effects other markdown features too

@mjbvz mjbvz added the candidate Issue identified as probable candidate for fixing in the next release label Oct 28, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 29, 2022
@mjbvz
Port md fixes to release branch
9a80738 
This is a cherry pick of two fixes:

- microsoft#164945 which fixes microsoft#164932 by picking up a new md language service version

- microsoft#164942 which fixes microsoft#164562 by fixing a bug with the md workspace implementation
@mjbvz mjbvz mentioned this issue Oct 29, 2022
Merged
mjbvz added a commit that referenced this issue Oct 31, 2022
@mjbvz
Port md fixes to release branch (#164986)
dd1e484 
This is a cherry pick of two fixes:

- #164945 which fixes #164932 by picking up a new md language service version

- #164942 which fixes #164562 by fixing a bug with the md workspace implementation
@mjbvz mjbvz closed this as completed Oct 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed labels Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
October 2022
6 participants
@weinand @rzhao271 @mjbvz @joyceerhl @andreamah @vscodenpa