Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channel's loglevel listener doesn't fire on when setting log level for "all" #164606

Closed
weinand opened this issue Oct 25, 2022 · 0 comments
Closed

channel's loglevel listener doesn't fire on when setting log level for "all" #164606

weinand opened this issue Oct 25, 2022 · 0 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Milestone
October 2022

Comments

@weinand
Copy link
Contributor

weinand commented Oct 25, 2022

Testing #164434

I have two "onDidChangeLogLevel" listeners: one on "vscode.env" and one on my channel and
I'm setting the log levels with this action:

CleanShot 2022-10-25 at 17 23 03@2x

In the test items description you said:

Configure log levels for all log channels using the command Set Log Level... and make sure
log level change is being propagated in env and also in your log output channel

For me only the listener on "vscode.env" fires.
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug log VS Code log issues labels Oct 26, 2022
@sandy081 sandy081 added this to the October 2022 milestone Oct 26, 2022
sandy081 added a commit that referenced this issue Oct 26, 2022
@sandy081
Fix #164606
10f8b5f
@sandy081 sandy081 mentioned this issue Oct 26, 2022
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Oct 26, 2022
@sandy081 sandy081 mentioned this issue Oct 26, 2022
Closed
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 27, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
@sandy081 @formigoni
Fix microsoft#164606 (microsoft#164714)
2ca3b08
@aeschli aeschli added the verified Verification succeeded label Oct 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
4 participants
@weinand @aeschli @sandy081 @vscodenpa