Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal quick fix lightbulb color is wrong #165434

Closed
meganrogge opened this issue Nov 3, 2022 · 2 comments · Fixed by #165440
Closed

terminal quick fix lightbulb color is wrong #165434

meganrogge opened this issue Nov 3, 2022 · 2 comments · Fixed by #165440
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verified Verification succeeded
Milestone
November 2022

Comments

@meganrogge
Copy link
Contributor

🤔

.terminal-command-decoration.quick-fix {
	color: var(--vscode-editorLightbulb-foreground) !important;
	background-color: var(--vscode-terminal-background, --vscode-panel-background);
}
@meganrogge meganrogge self-assigned this Nov 3, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-quick-fix labels Nov 3, 2022
@meganrogge meganrogge added this to the November 2022 milestone Nov 3, 2022
@meganrogge meganrogge mentioned this issue Nov 3, 2022
Merged
@meganrogge
Copy link
Contributor Author

in dev tools, the color --vscode-editorLightbulb-foreground is not yet defined when it's requested

@meganrogge
Copy link
Contributor Author

oh it should be --vscode-editorLightBulb-foreground 🤦🏼‍♀️

meganrogge added a commit that referenced this issue Nov 3, 2022
@meganrogge
fix #165434
77ce8ea
meganrogge added a commit that referenced this issue Nov 3, 2022
@meganrogge
fix #165434
5581dca
@meganrogge meganrogge mentioned this issue Nov 3, 2022
Merged
meganrogge added a commit that referenced this issue Nov 4, 2022
@meganrogge
fix #165434 (#165440)
e764c5b
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@andreamah andreamah added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

fix #165434 microsoft/vscode
3 participants
@meganrogge @andreamah @vscodenpa