Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter bootstrap_node.js by default #16686

Closed
chrmarti opened this issue Dec 6, 2016 · 5 comments
Closed

Don't filter bootstrap_node.js by default #16686

chrmarti opened this issue Dec 6, 2016 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Dec 6, 2016

  • VSCode Version: Code - Insiders 1.8.0-insider (7499a9f, 2016-12-06T16:10:17.195Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
vscode-docker PeterJausovec 0.0.7
regex chrmarti 0.0.7
vscode-eslint dbaeumer 1.1.0
ghlink dt 0.0.4
tslint eg2 0.6.0
PowerShell ms-vscode 0.7.2
debugger-for-chrome msjsdiag 2.2.2
diff rafaelmaiolla 0.0.1
vscode-open-in-github sysoev 1.2.1

Steps to Reproduce:

  1. Step into console.log('something') with node2
  2. Observe that the debugger stops in bootstrap_node.js

With the default adapter node bootstrap_node.js is skipped.

@chrmarti
Copy link
Collaborator Author

chrmarti commented Dec 6, 2016

(Testing #16208)

@roblourens
Copy link
Member

Did you have some skipFiles or smartStep option set? I don't see 'node' skipping it by default and I don't think we should skip anything by default.

@chrmarti
Copy link
Collaborator Author

chrmarti commented Dec 6, 2016

See https://github.com/chrmarti/skipFiles-test/blob/master/test.js
Steps:

  1. Set breakpoint on line 4 of test.js
  2. Start debugging
  3. Debugger stops on line 4 of test.js
  4. Step in
  5. a) node2 steps into bootstrap_node.js (seems to do 2 step ins in one)
  6. b) node stops at line 5 of test.js, keep stepping in, doesn't stop in bootstrap_node.js

@roblourens
Copy link
Member

I think node2 is correct. Without skipFiles, node can step into bootstrap_node.js, so it should when it's not skipped as well.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 7, 2016
@weinand weinand added this to the November 2016 milestone Dec 7, 2016
@roblourens roblourens changed the title Filter bootstrap_node.js by default (node2) Don't filter bootstrap_node.js by default Dec 8, 2016
@roblourens roblourens removed their assignment Dec 8, 2016
@weinand
Copy link
Contributor

weinand commented Dec 8, 2016

The just-my-code implementation in node was skipping internal modules (because they were missing an absolute path). I've created a feature request for supporting internal modules explicitly.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants