Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Having skipFiles will skip native node APIs when using node but not with node2 #16854

Closed
Tyriar opened this issue Dec 7, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2016

#16208

  • VSCode Version: Code - Insiders 1.8.0-insider (0d65ced, 2016-12-07T07:04:22.691Z)
  • OS Version: Linux x64 4.8.0-27-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
lorem-ipsum Tyriar 1.0.0
theme-glacier Tyriar 0.0.10
vscode-svgviewer cssho 1.2.0
python donjayamanne 0.5.5
tslint eg2 0.7.1
git-project-manager felipecaputo 1.0.0
Theme-Wombat gerane 0.0.2
md-navigate jrieken 0.0.1
Go lukehoban 0.6.50
vscode-scss mrmlnc 0.6.0
csharp ms-vscode 1.5.3
java redhat 0.0.7
annotator ryu1kn 0.10.1

  1. Clone and open https://github.com/Microsoft/vscode-smoketest-express.git

  2. Created the launch.json:

    {
        // Use IntelliSense to learn about possible Node.js debug attributes.
        // Hover to view descriptions of existing attributes.
        // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
        "version": "0.2.0",
        "configurations": [
            {
                "type": "node",
                "request": "launch",
                "name": "Launch Program",
                "program": "${workspaceRoot}/bin/www",
                "cwd": "${workspaceRoot}",
                "skipFiles": [
                    "node_modules/**" // Intentionally doesn't match `http` module
                ]
            },
            {
                "type": "node",
                "request": "attach",
                "name": "Attach to Process",
                "port": 5858
            }
        ]
    }
  3. Put a breakpoint at bin/www:28 on server.listen

  4. Start debugging

  5. Hit the breakpoint

  6. Step in, notice http is skipped

  7. Change type to node2 in launch.json

  8. Start debugging

  9. Hit the breakpoint

  10. Step in, notice http is not skipped

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 7, 2016
@weinand weinand added this to the November 2016 milestone Dec 7, 2016
@weinand
Copy link
Contributor

weinand commented Dec 8, 2016

dup of #16686

@weinand weinand closed this as completed Dec 8, 2016
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 9, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants