Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test indentSize #167471

Closed
2 tasks done
alexdima opened this issue Nov 28, 2022 · 0 comments
Closed
2 tasks done

Test indentSize #167471

alexdima opened this issue Nov 28, 2022 · 0 comments
Assignees
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Nov 28, 2022

Refs #10339 #135058

Complexity: 3

Create Issue


We have now a new setting, editor.indentSize. This allows, when indenting with spaces (editor.insertSpaces: true) to disassociate the tab character (\t) render width (tabSize) from the number of spaces that make up an indent (indentSize). Please check that:

  • by default, the indentSize setting has the value "tabSize" (by default there is no change in behavior).
  • when detecting indentation, indentSize is always detected to be equal to tabSize (unchanged from before).
  • try a file like https://github.com/StarCrossPortal/ghidracraft/blob/a960e81ff6144ec8834e187f5097dfcf64758e18/Ghidra/Features/Decompiler/src/decompile/cpp/cast.cc#L47
    • configure: editor.detectIndentation: false, editor.insertSpaces: true, editor.tabSize: 8, editor.indentSize: 2 and verify this makes the code "line up".
    • it is also possible to change the settings from the status bar. First, make sure the text buffer is configured to indent with spaces. Then, click on Spaces:N and choose Change Tab Display Size. This allows you to configure different values for tabSize compared to indentSize.
@alexdima alexdima added this to the November 2022 milestone Nov 28, 2022
@ghost ghost assigned mjbvz and hediet Nov 29, 2022
@hediet hediet removed their assignment Nov 29, 2022
@mjbvz mjbvz closed this as completed Nov 29, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 29, 2022
mjbvz added a commit that referenced this issue Nov 29, 2022
…67603)

Show default string value as code in setting description

From testing #167471
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants