-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize or remove the notebookControllerKind API Proposal #168535
Comments
I'm leaning towards removing this API though we have seen interest in it. It was introduced to help us group controllers in the kernel picker, but now we are moving towards MRU. It would be a degraded experience if we remove it before having more users using the new MRU kernel picker. With that said, I'm open to proposals to have it finalized if we find good use of it. |
Pinging @davidanthoff because of microsoft/vscode-jupyter#7373 (comment) @mjbvz your comment that Jupyter is the only current consumer of it may be because it's still only proposed API. Not many extensions get the special privilege of being able to use proposed APIs and be published on Marketplace. |
From Julia's point of view, I could see the new MRU experience replacing this. Agreed with @rebornix that the kind property shouldn't be removed until the MRU is finalized and default, otherwise the experience would really not be good. With the Jupyter extension installed, things look like this to me: A few comments on that:
|
@davidanthoff thanks for your feedback, they make good sense and we have discussed some of the wording, like using "Jupyter Kernel Specs". We will address other feedback in issue #168647 |
Actually, here is another idea: if the In the new MRU UI, could the That would enable a scenario where things move forward now before the MRU story is finalized, and then there would also be a use-case for the Also, I think this issue here is a dup of #168535, but given that more discussion has happened here, it probably makes sense to close #168535 and continue here. |
For microsoft#168535 As discussed, we will stop showing the `kind` in the new MRU kernel quick pick
Don't use kind in kernel MRU quick pick For #168535 As discussed, we will stop showing the `kind` in the new MRU kernel quick pick
Don't use kind in kernel MRU quick pick For microsoft#168535 As discussed, we will stop showing the `kind` in the new MRU kernel quick pick
* Remove the flat kernel picker For #168535 * Adding stubs for unit tests * Remove unnecessary test for old kernel picker. --------- Co-authored-by: rebornix <penn.lv@gmail.com>
From microsoft/vscode-jupyter#7373
Let's figure out what to do with the
notebookControllerKind
API proposal. Jupyter is currently the only consumer of it@rebornix @DonJayamanne Can you please let me know:
The text was updated successfully, but these errors were encountered: