Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log sizes of extension host telemetry messages #170955

Closed
jrieken opened this issue Jan 10, 2023 · 0 comments
Closed

Log sizes of extension host telemetry messages #170955

jrieken opened this issue Jan 10, 2023 · 0 comments
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. extension-host Extension host issues perf
Milestone
January 2023

Comments

@jrieken
Copy link
Member

jrieken commented Jan 10, 2023

re #170954

We know from telemetry that deserialising and serialising RPC messages can become costly and this issue to follow up on that. For now, let's add telemetry if any of the API implementations send or receive unexpected large amount of data. We usually cap those but it is likely that we are missing a couple of cases
@jrieken jrieken self-assigned this Jan 10, 2023
@jrieken jrieken added extension-host Extension host issues perf engineering VS Code - Build / issue tracking / etc. labels Jan 10, 2023
@jrieken jrieken added this to the January 2023 milestone Jan 10, 2023
jrieken added a commit that referenced this issue Jan 10, 2023
@jrieken
add RPC telemetry
808b4f0 
Make clients (with a low chance of 0.5%) log the sizes of RPC requests and replies. #170955
@jrieken jrieken mentioned this issue Jan 10, 2023
Merged
jrieken added a commit that referenced this issue Jan 10, 2023
@jrieken
add RPC telemetry (#170956)
0124c36 
* add RPC telemetry

Make clients (with a low chance of 0.5%) log the sizes of RPC requests and replies. #170955

* update telemetry name
@kieferrm kieferrm mentioned this issue Jan 17, 2023
Closed
@jrieken jrieken mentioned this issue Jan 20, 2023
Merged
jrieken added a commit that referenced this issue Jan 20, 2023
@jrieken
further reduce how often RPC sizes are logged
e83bb5c 
#170955
jrieken added a commit that referenced this issue Jan 20, 2023
@jrieken
further reduce how often RPC sizes are logged (#171799)
6a0a932 
#170955
@jrieken jrieken closed this as completed Jan 23, 2023
@jrieken jrieken mentioned this issue Jan 23, 2023
Open
@kieferrm kieferrm mentioned this issue Feb 4, 2023
Closed
92 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. extension-host Extension host issues perf
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
1 participant
@jrieken