Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot navigate w arrow keys in terminal accessibility buffer #172222

Closed
meganrogge opened this issue Jan 24, 2023 · 3 comments · Fixed by #172276
Closed

cannot navigate w arrow keys in terminal accessibility buffer #172222

meganrogge opened this issue Jan 24, 2023 · 3 comments · Fixed by #172276
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Something that used to work is now broken verified Verification succeeded
Milestone
February 2023

Comments

@meganrogge
Copy link
Contributor

inserting adjacent is the problem - needs to be this._terminal.element?.appendChild(this._accessibilityTreeRoot);

specifically xtermjs/xterm.js#4382 (comment)

elt.mov
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues regression Something that used to work is now broken labels Jan 24, 2023
@meganrogge meganrogge added this to the January 2023 milestone Jan 24, 2023
@meganrogge meganrogge mentioned this issue Jan 24, 2023
Merged
@meganrogge meganrogge changed the title in oss on mac, cannot navigate w arrow keys in terminal accessibility buffer cannot navigate w arrow keys in terminal accessibility buffer Jan 24, 2023
@meganrogge meganrogge mentioned this issue Jan 24, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 25, 2023
@meganrogge
Copy link
Contributor Author

this is still a problem today in oss off of main

arrow.mov

@meganrogge meganrogge reopened this Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Jan 25, 2023
@meganrogge
Copy link
Contributor Author

Oh, in dev tools OSS is showing the readonly property still for some reason, so maybe this is actually fixed

Screenshot 2023-01-25 at 9 25 06 AM

@bhavyaus bhavyaus added the verification-steps-needed Steps to verify are needed for verification label Jan 26, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 27, 2023
@rzhao271
Copy link
Contributor

LGTM on Windows

@meganrogge meganrogge removed the verification-steps-needed Steps to verify are needed for verification label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

xterm@5.2.0-beta.21 microsoft/vscode
5 participants
@Tyriar @rzhao271 @bhavyaus @meganrogge @VSCodeTriageBot