Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm@5.2.0-beta.21 #172276

Merged
merged 2 commits into from
Jan 25, 2023
Merged

xterm@5.2.0-beta.21 #172276

merged 2 commits into from
Jan 25, 2023

Conversation

meganrogge
Copy link
Contributor

fix #172222

@meganrogge meganrogge self-assigned this Jan 24, 2023
@meganrogge meganrogge added this to the January 2023 milestone Jan 24, 2023
@jooyoungseo
Copy link

@meganrogge -- Yep, this resolves the regression. Did the readonly introduce the inadvertent regression? Now deletion key works again in the buffer.

FYI, aria-live works nicely; however, line-by-line navigation mode via Ctrl+UpArrow/DownArrow keeps saying 1 of 21, 10 of 21, etc. without any actual content being read.

@meganrogge
Copy link
Contributor Author

@jooyoungseo the regression was in removing a line which inserted the .xterm-accessibility element into the dom 😅 when we added the .xterm-accessibility-buffer

From @Tyriar: Readonly was causing up/down to scroll instead of move a cursor around. This is probably up to the browser, but we want this to also work for non-screen reader users for keyboard accessible selection.

Re navigation mode, ok we will look into that - as we've said, we're hoping this new accessible buffer can replace the need for that

@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2023

With readonly unfortunately Electron surprisingly didn't use a cursor, we want this for non-screen reader users for keyboard selection support as well.

@meganrogge meganrogge enabled auto-merge (squash) January 25, 2023 12:50
@meganrogge meganrogge closed this Jan 25, 2023
auto-merge was automatically disabled January 25, 2023 13:16

Pull request was closed

@meganrogge meganrogge reopened this Jan 25, 2023
@meganrogge meganrogge enabled auto-merge (squash) January 25, 2023 13:16
@meganrogge meganrogge merged commit 7d08b7f into main Jan 25, 2023
@meganrogge meganrogge deleted the merogge/ree branch January 25, 2023 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot navigate w arrow keys in terminal accessibility buffer
4 participants