Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Continue On between repos with HTTPS and SSH remotes #172341

Closed
kieferrm opened this issue Jan 25, 2023 · 2 comments · Fixed by #182352
Closed

Cannot Continue On between repos with HTTPS and SSH remotes #172341

kieferrm opened this issue Jan 25, 2023 · 2 comments · Fixed by #182352
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Jan 25, 2023

Testing #172042

Version: 1.75.0-insider
Commit: 0a6c277
Date: 2023-01-24T05:22:29.430Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Darwin arm64 21.6.0
Sandboxed: Yes

  1. window with locally cloned private repo with uncommitted changes
  2. Cloud changes turned on
  3. Continue On: Open on vscode.dev

-> repo opens on insiders.vscode.dev and I need to sign in to GH
-> cloud changes are showing as turned on
-> no uncommitted changes show up

Local log:

2023-01-24 17:39:39.391 [info] Storing edit session...
2023-01-24 17:39:39.984 [info] Stored edit session with ref aeef5fac-5e56-4090-bf4f-7d4dcb429d95.
2023-01-24 17:39:39.990 [info] Opening https://insiders.vscode.dev/github/kieferrm/myrepo/blob/main/file.md?editSessionId%3Daeef5fac-5e56-4090-bf4f-7d4dcb429d95%26continueOn%3D1#L27

Cloud changes log in the web:

2023-01-24 17:39:47.615 [info] Resuming cloud changes, reason: found editSessionId aeef5fac-5e56-4090-bf4f-7d4dcb429d95 in environment service...
2023-01-24 17:39:47.826 [info] Resuming changes from cloud with ref aeef5fac-5e56-4090-bf4f-7d4dcb429d95...
2023-01-24 17:40:00.574 [info] Matching identity {"remote":"https://github.com/kieferrm/myrepo","ref":"master","sha":"612327c69855342d20100b73bcd0a61631f7c9c7"} against edit session folder identity {"remote":"git@github.com:kieferrm/myrepo.git","ref":"master","sha":"612327c69855342d20100b73bcd0a61631f7c9c7"}...
2023-01-24 17:40:00.678 [info] Skipping applying 3 changes from edit session with ref aeef5fac-5e56-4090-bf4f-7d4dcb429d95 as no matching workspace folder was found.
@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2023
@joyceerhl
Copy link
Collaborator

This is because the local git repo has a GitHub SSH remote and the remote repo reports GitHub HTTPS remotes. There's no generic way to translate a SSH remote to an HTTPS one, but we can add that logic in the providers in RemoteHub to mitigate this.

We can't introduce a RemoteHub setting to control which remote type gets used because by default Codespaces uses HTTPS remotes, so enabling such a setting would break Continue On to a codespace.

@joyceerhl
Copy link
Collaborator

API proposal for this: #180582

@joyceerhl joyceerhl changed the title Missing uncommitted changes Allow Continue On between repos with HTTPS and SSH remotes May 15, 2023
@joyceerhl joyceerhl changed the title Allow Continue On between repos with HTTPS and SSH remotes Cannot Continue On between repos with HTTPS and SSH remotes May 15, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants