Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellscript filenamePatterns for .env* #173425

Closed
thernstig opened this issue Feb 4, 2023 · 1 comment · Fixed by #173426
Closed

Add shellscript filenamePatterns for .env* #173425

thernstig opened this issue Feb 4, 2023 · 1 comment · Fixed by #173426
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@thernstig
Copy link
Contributor

In some cases, projects use .env files such as .env.development or .env.production or similar things.

Adding this to extensions/shellscript/package.json as a filenamePatterns avoids developers having to add specific "files.associations" to their VS Code settings files.

@alexr00 alexr00 assigned alexr00 and unassigned jrieken Feb 6, 2023
@alexr00 alexr00 added feature-request Request for new features or functionality and removed triage-needed labels Feb 6, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Feb 6, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@alexr00 alexr00 modified the milestones: Backlog Candidates, Backlog Feb 6, 2023
@alexr00 alexr00 added the languages-basic Basic language support issues label Feb 6, 2023
alexr00 pushed a commit that referenced this issue Feb 10, 2023
* Add shellscript `filenamePatterns` for `.env*`

In some cases, projects use `.env` files such as `.env.development`
or `.env.production` or similar things.

Adding this to extensions/shellscript/package.json as a
`filenamePatterns` avoids developers having to add specific
`"files.associations"` to their VS Code settings files.

Fixes #173425

* Change pattern from .env* to .env.*
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 10, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
* Add shellscript `filenamePatterns` for `.env*`

In some cases, projects use `.env` files such as `.env.development`
or `.env.production` or similar things.

Adding this to extensions/shellscript/package.json as a
`filenamePatterns` avoids developers having to add specific
`"files.associations"` to their VS Code settings files.

Fixes microsoft#173425

* Change pattern from .env* to .env.*
@rzhao271 rzhao271 modified the milestones: Backlog, February 2023 Feb 21, 2023
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Feb 22, 2023
@jrieken jrieken added the verified Verification succeeded label Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants