"find all references" previously highlighted "find all references" word remains highlighted

[gujiman]

#- VSCode Version: 1.8.0

• OS Version: win 7

Steps to Reproduce:

1. Open any type of file where by a keyword may be used in multiple files. I.e we have 2 Files and both have keywords used in both files:

File 1:

function a(){
return 1;
}
b();

---

File 2:

function b(){
return 1;
}
a();

---

2. Now select a() from file 1 and right click and select "find all references" to open the "find all references" box.
3. You have to toggle both files in the "find all references" box (do it a couple of times).
4. Close the "Find in File" box.
5. Now select b() and repeat step 2 and 3. As you will see that the previously highlighted b() is still highlighted.

[rebornix]

@gujiman can you help confirm above gif represents what you are describing? Are you saying that in step 5, b() is still highlighted in the sidebar?

cc @roblourens it looks like that the search sidebar is not cleaned even though that it's hidden before we run Find in files

[gujiman]

hi,

Im really sorry about this but the problem was in "find all references" feature not "find in files" feature!

[gujiman]

@roblourens just wondering why the issue was closed. I have sent the following screenshot which shows the bug (which seems that the highlighted keyword from the the previous "find all references" result "a()" does not go away when doing a "find all references" for "b()"):

[rebornix]

@gujiman no worries. it' a valid issue about Find all reference.

[roblourens]

Sorry for closing it, I misread

[gujiman]

no probs. Brilliant software by the way

[rebornix]

@gujiman excellent finding actually, it's a bug in the reference widget. I like your reproduce steps.