Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resuming cloud changes created in unrelated context #174383

Closed
TylerLeonhardt opened this issue Feb 14, 2023 · 2 comments · Fixed by #175593
Closed

Allow resuming cloud changes created in unrelated context #174383

TylerLeonhardt opened this issue Feb 14, 2023 · 2 comments · Fixed by #175593
Assignees
Labels
cloud-changes feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Show Cloud Changes
  2. Click on the button:

image

1. spinner appears but no changes are made locally

at least my change doesn't go away.

Logs don't indicate anything interesting

2023-02-14 10:07:55.755 [trace] Sending request to server {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions/6fc9a0f3-9295-456f-8231-2545379a8bca","type":"GET","headers":{"X-Execution-Id":"2fdb13d0-3cd5-4133-86ae-139e0c87dda5","Cache-Control":"no-cache","X-Client-Name":"code-insiders","X-Client-Version":"1.76.0-insider","X-Client-Commit":"af4a70d991053dcbf64d9a86c76a02dced81d9c4","X-Account-Type":"github","X-Machine-Session-Id":"443803c0-8aba-4f32-aa0f-15cd86b156bf","X-User-Session-Id":"2169eda5-f8e5-4637-88e7-f111778e8200"}}
2023-02-14 10:07:55.758 [trace] Sending request to server {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions/6fc9a0f3-9295-456f-8231-2545379a8bca","type":"GET","headers":{"X-Execution-Id":"d10b8282-4321-4762-a743-1a20b4c31543","Cache-Control":"no-cache","X-Client-Name":"code-insiders","X-Client-Version":"1.76.0-insider","X-Client-Commit":"af4a70d991053dcbf64d9a86c76a02dced81d9c4","X-Account-Type":"github","X-Machine-Session-Id":"443803c0-8aba-4f32-aa0f-15cd86b156bf","X-User-Session-Id":"2169eda5-f8e5-4637-88e7-f111778e8200"}}
2023-02-14 10:07:56.194 [trace] Request succeeded {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions/6fc9a0f3-9295-456f-8231-2545379a8bca","status":200,"execution-id":"2fdb13d0-3cd5-4133-86ae-139e0c87dda5"}
2023-02-14 10:07:56.716 [trace] Request succeeded {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions/6fc9a0f3-9295-456f-8231-2545379a8bca","status":200,"execution-id":"d10b8282-4321-4762-a743-1a20b4c31543"}
@joyceerhl joyceerhl added feature-request Request for new features or functionality cloud-changes labels Feb 16, 2023
@joyceerhl joyceerhl changed the title Cloud Changes not restoring Allow resuming cloud changes created in unrelated context Feb 16, 2023
@joyceerhl joyceerhl added this to the Backlog milestone Feb 16, 2023
@zombiezen
Copy link

I encountered this issue myself because I had branches that had the same name locally, but their upstream branches were set differently. My local workaround was to git branch --set-upstream-to=origin/foo to get Cloud Changes to do the right thing, but the only way I figured this out was by looking at logs. It would be nice for Cloud Changes to at the very least show an error message or something when I click "Resume Working Changes" but it intentionally no-ops.

@joyceerhl joyceerhl modified the milestones: Backlog, March 2023 Feb 27, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 27, 2023
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Mar 20, 2023
@eleanorjboyd eleanorjboyd added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded verification-needed Verification of issue is requested labels Mar 21, 2023
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Mar 21, 2023
@eleanorjboyd eleanorjboyd removed the verification-found Issue verification failed label Mar 21, 2023
@connor4312 connor4312 added ~version-info-needed Issue requires version information from poster verified Verification succeeded and removed ~version-info-needed Issue requires version information from poster labels Mar 21, 2023
@vscodenpa vscodenpa added the info-needed Issue requires more information from poster label Mar 21, 2023
@microsoft microsoft deleted a comment from vscodenpa Mar 21, 2023
@connor4312 connor4312 removed the info-needed Issue requires more information from poster label Mar 21, 2023
@connor4312
Copy link
Member

sorry, misclicked a label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cloud-changes feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants