Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open User Settings (JSON) command should open current profile settings while in a profile #175598

Closed
rzhao271 opened this issue Feb 27, 2023 · 2 comments · Fixed by #186952
Closed
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Feb 27, 2023

Ref #173841 (comment)
Ref #156144

When a user switches profiles, what is considered the "user settings" changes, where

  • Application-scoped settings are still saved to the default profile's settings.json
  • Other user settings are saved to the current profile's settings.json

The current commands are "Open User Settings (JSON)" and "Open Current Profile Settings (JSON)". One idea is to have the commands be "Open Application Settings (JSON)" and "Open User Settings (JSON)" instead.

I'll leave this issue open in case anyone has any feedback. Also feel free to vote on the issue even though it's not filed under Backlog Candidates.

@rzhao271 rzhao271 added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Feb 27, 2023
@rzhao271 rzhao271 added this to the March 2023 milestone Feb 27, 2023
@rzhao271 rzhao271 self-assigned this Feb 27, 2023
@Ramin-RX7
Copy link

I still find this a bit confusing. At first I thought user settings is the global settings that we want the user to have for all of his different profiles. for example files.autoSaveDelay.
and profile setting will be a type of configuration that dives deeper in details like python.linting.mypyEnabled
But it seems no. I'm totally misunderstanding this topic. So is there any documentation that differentiate between these expressions we use like user, profile, global, Application-scoped, etc. settings and show their relations?

One idea is to have the commands be "Open Application Settings (JSON)"

IMO this won't be a good command since not only the application settings/configs do not necessarily need to be separated but also it's still a bit confusing like other settings that were mentioned

@isidorn
Copy link
Contributor

isidorn commented Mar 3, 2023

+1 for cleaning up things here.
Have separate commands in the command palette makes sense.

What are your thoughts on the Setting title area action? Is there concern that the current flow is confusing to the users? Could we just open the Profile settings?

Thank you!

@rzhao271 rzhao271 modified the milestones: March 2023, April 2023 Mar 21, 2023
@rzhao271 rzhao271 modified the milestones: April 2023, May 2023 Apr 21, 2023
@rzhao271 rzhao271 modified the milestones: May 2023, June 2023 May 25, 2023
@rzhao271 rzhao271 modified the milestones: June 2023, July 2023 Jun 23, 2023
rzhao271 added a commit that referenced this issue Jul 3, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 5, 2023
@andreamah andreamah added the verification-needed Verification of issue is requested label Jul 24, 2023
@sandy081 sandy081 added the verified Verification succeeded label Jul 25, 2023
@rzhao271 rzhao271 added the on-release-notes Issue/pull request mentioned in release notes label Jul 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants