Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook cell complete audio cue didn't play if kernel was selected in same execution action #176284

Closed
Tracked by #178630
amunger opened this issue Mar 6, 2023 · 8 comments · Fixed by #179204
Closed
Tracked by #178630
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook-output
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Mar 6, 2023

  1. enable audio cues for notebook cell completion
  2. open a notebook without a kernel selected and run a cell
  3. select the kernel so that the cell runs successfully
    🐛 cell completes, but audio cue doesn't play
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Mar 6, 2023
@amunger amunger added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed notebook-accessibility labels Mar 6, 2023
@meganrogge meganrogge added this to the April 2023 milestone Mar 30, 2023
@meganrogge
Copy link
Contributor

to be clear, @amunger, you were using run by line here to do this, correct? As you can see here, there's no run button when i haven't selected a kernel.
Screenshot 2023-04-04 at 1 42 46 PM

@amunger
Copy link
Contributor Author

amunger commented Apr 4, 2023

shift+enter should also trigger the cell to run. Do you have any kernels available in that screenshot? I can still see a run button without a kernel selected.

@meganrogge
Copy link
Contributor

shift + enter adds a new line to the cell and no I don't have any kernels available by design, as it seems it gets auto selected.

what were your more specific repro steps for the above? I've been disabling the python extension to simulate no kernel selected then pressing run by line

@meganrogge
Copy link
Contributor

I was hoping one of these would allow me to reset it such that there are no kernels, but no luck
Screenshot 2023-04-04 at 1 55 00 PM

@meganrogge
Copy link
Contributor

oh figured it out- just creating a new notebook

@meganrogge
Copy link
Contributor

nice, here's the issue

Screenshot 2023-04-04 at 1 58 30 PM

@meganrogge
Copy link
Contributor

looks like there's a chrome / maybe chromium flag that allows you to bypass this policy:

--autoplay-policy=no-user-gesture-required

meganrogge added a commit that referenced this issue Apr 4, 2023
meganrogge added a commit that referenced this issue Apr 5, 2023
This reverts commit 68f61c1.
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 5, 2023
@meganrogge meganrogge modified the milestones: April 2023, Backlog Apr 6, 2023
@meganrogge meganrogge reopened this Apr 6, 2023
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Apr 6, 2023
@meganrogge
Copy link
Contributor

@rebornix @amunger I think we should close this since we know the fix that would be required and cannot action it due to side effects. thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook-output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants