You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Very very nice. I like that this moves the heavy lifting for theme keys back to the file icon side. Minor notes:
The attributes contributed in iconLabel.ts need to use data- attributes for HTML5 semantic correctness.
If we don't do this, we will get ⚠ warnings in the devtools console.
We can support surrounding wildcards (as in *selector*) using [attr*="selector"] in CSS service
I believe I might have thought of this in #12493 but didn't devise it or sketch it out.
I guess I was just hyper-focused on getting the original use cases implemented in linear time 😄
Thanks @zm-cttae. I agree with all your points!
Yes, the idea is that the patterns can also be used for extensions
Still to be clarified is how we deal with multi-segment extensions: hello.test.ts. Right now we generate multiple class names test.ts-ext-file-icon and ts-ext-file-icon and icon themes can match again ts or test.ts
Maybe move the dot inside the extension and use the $ to match?
We currently use css classes to match file icons to file names.
Using attribute selectors could simplify this and allow to support name patterns
The text was updated successfully, but these errors were encountered: