Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR][Terminal] allow addons to be added/enable/disable #17897

Closed
farfromrefug opened this issue Dec 29, 2016 · 1 comment
Closed

[FR][Terminal] allow addons to be added/enable/disable #17897

farfromrefug opened this issue Dec 29, 2016 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@farfromrefug
Copy link

xterm.js already have a few interested addons.The one that would be especially useful for vscode is the linkify one.

Would be great to have the possibility to enable that addon from the API. The same it would be great for extensions to be able to add their own custom xterm addons.

Related discussion: #17678

@Tyriar
Copy link
Member

Tyriar commented Jan 3, 2017

So linkify is currently broken upstream (xtermjs/xterm.js#27) and I wouldn't be surprised if it doesn't work at all anymore since I don't think anyone has looked at it in a while. There are a bunch of other issues as well.

My plan with linkify was to wait until it's worked out upstream either by myself or another contributor and then mold it so it works with VS Code. This may need to be put into xterm.js' core depending on how it performs. Also simply enabling addons will not just let it work as xterm.js is build for the browser, not electron. linkify adds <a> tags which will need to be handled specially within VS Code and thus will need tighter integration. Here's the feature request for that #7321

I'm going to close this off as I don't see this ever happening due to the browser/electron issue. In the meantime you can upvote #7321 which will help bump it higher in my queue.

@Tyriar Tyriar closed this as completed Jan 3, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants