Cannot jump to file from Integrated Terminal

[ucirello]

• VSCode Version: 1.2
• OS Version: OS X

Steps to Reproduce:

1. Open the terminal and make a compilation error in your favorite language
2. Click on the file name it won't jump to the chosen file.

--> Monitor: Files changed, Building...
go build -v -i
github.com/REDACTED/REDACTED-ms/REDACTED
REDACTED/crumb.go:223: undefined: rpcCall

When selecting and clicking on REDACTED/crumb.go:223 it won't jump to the file.

Check how iTerm2 and ACME addresses this issue.

[TurkeyMan]

👍 Do want!
Clicking on errors should jump to the error like in any regular output window.

[tht13]

The latest insiders build has a command workbench.action.terminal.focus which is both available in the F1 command palette under "Focus Terminal" and available to attach to a keybinding.

[ucirello]

@tht13 what you said does not address the issue.

[tht13]

Apologies, I'm not sure why I thought that was relevant

[Tyriar]

Doing this will likely be based on xterm.js' linkify addon which is currently not production ready. So this is blocked on xtermjs/xterm.js#27

[kaiserdan]

This would especially be handy for js stack traces

[Tyriar]

Keeping this open to track as there will be some integration work to do once it's implemented upstream.

[Tyriar]

I gave an update to this in #17897 (comment):

My plan with linkify was to wait until it's worked out upstream either by myself or another contributor and then mold it so it works with VS Code. This may need to be put into xterm.js' core depending on how it performs. Also simply enabling addons will not just let it work as xterm.js is build for the browser, not electron. linkify adds <a> tags which will need to be handled specially within VS Code and thus will need tighter integration.