Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow inline providers to opt in to showing inline completions at the same time as completions #179134

Closed
hediet opened this issue Apr 4, 2023 · 3 comments
Closed

Allow inline providers to opt in to showing inline completions at the same time as completions #179134

hediet opened this issue Apr 4, 2023 · 3 comments
Assignees
@hediet
Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2023

Comments

@hediet
Copy link
Member

hediet commented Apr 4, 2023 •
edited
Loading

Verify in playground
@hediet hediet added feature-request Request for new features or functionality inline-completions labels Apr 4, 2023
@hediet hediet added this to the April 2023 milestone Apr 4, 2023
@hediet hediet self-assigned this Apr 4, 2023
@hediet hediet added the plan-item VS Code - planned item for upcoming label Apr 4, 2023
@kieferrm kieferrm mentioned this issue Apr 6, 2023
Closed
90 tasks
@hediet hediet mentioned this issue Apr 14, 2023
Closed
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Fixes #179134. Adds flag suppressSuggestions to inline completion res…
63c0489 
…ult.
@hediet hediet closed this as completed in 732f21c Apr 17, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 17, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Apr 24, 2023
@roblourens
Copy link
Member

I think this works but I'm a little confused about how this sample works, am I supposed to see something different in each group? I think I see the exact same result after each ----

image

@roblourens roblourens added the verified Verification succeeded label Apr 25, 2023
@hediet
Copy link
Member Author

hediet commented Apr 26, 2023

You should see this:

02ulP83JFC

@roblourens
Copy link
Member

roblourens commented Apr 28, 2023 •
edited
Loading

That's exactly what I see today. Not sure what I was doing wrong earlier

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

No branches or pull requests
3 participants
@roblourens @hediet @vscodenpa