Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Explore notebook.codeActionsOnSave #180765

Closed
3 tasks done
Yoyokrazy opened this issue Apr 24, 2023 · 1 comment
Closed
3 tasks done

Test: Explore notebook.codeActionsOnSave #180765

Yoyokrazy opened this issue Apr 24, 2023 · 1 comment
Labels
testplan-item
Milestone
April 2023

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Apr 24, 2023 •
edited by sandy081
Loading

Refs: #179213

Complexity: 2

Authors: @Yoyokrazy

Create Issue

Summary:

Notebooks now have preliminary support for CodeActions on save. Currently, that allows the user to execute a set of pre-defined commands (not specifically CodeActions) upon the saving of their notebook.

Steps to Test:

  • Create a new or open a pre-existing notebook
  • Go to Settings (UI) and search for notebook.codeActionsOnSave
  • Add several commands to this setting
  • Save the notebook, which should run all commands defined in settings
  • Adjust boolean values of commands, ensuring that it changes whether or not the command runs
  • Have fun! Play around with this, tweak your notebook workflow, find some bugs.

image

Things to check

  • The commands all executed (or didn't) as expected given boolean values.
  • The notebook saved.
  • Saving of the notebook occurred after all actions.
@Yoyokrazy Yoyokrazy added this to the April 2023 milestone Apr 24, 2023
@ghost ghost assigned jrieken, sbatten and roblourens Apr 25, 2023
@jrieken jrieken mentioned this issue Apr 25, 2023
Closed
@sbatten sbatten removed their assignment Apr 25, 2023
@roblourens
Copy link
Member

Works as advertised but I agree with #180839 that it should be based on code actions, not commands

@roblourens roblourens mentioned this issue Apr 25, 2023
Closed
@roblourens roblourens removed their assignment Apr 25, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Apr 25, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
April 2023
Development

No branches or pull requests
5 participants
@roblourens @jrieken @sbatten @sandy081 @Yoyokrazy