Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear how to use notebook.codeActionsOnSave and editor.codeActionsOnSave #180846

Closed
roblourens opened this issue Apr 25, 2023 · 2 comments
Closed
Assignees
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Apr 25, 2023

Testing #180765

If I'm just looking at these settings for the first time, it's not clear what the shape of the object is supposed to be, or what the boolean value means.

Also, the notebook setting's description says "a series of codeactions" which implies that there is some order, does it always run the commands in the order of keys in the object or is the order not guaranteed?

@Yoyokrazy Yoyokrazy added this to the May 2023 milestone Apr 25, 2023
@Yoyokrazy
Copy link
Contributor

Had a couple chats offline, I'll just be removing the setting for now. It'll likely be reintroduced alongside proper codeaction support later on in the next iteration. There was a misunderstanding surrounding the behavior of editor.codeActionsOnSave, which led to nb.codeActionsOnSave picking up the different functionality.

@Yoyokrazy
Copy link
Contributor

Closing due to revised functionality, this is outdated in regard to the current implementation.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants