Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward and backward of trackpad in Webview should be disabled? #182013

Closed
yiliang114 opened this issue May 10, 2023 · 5 comments · Fixed by #184677, #187624 or #189000
Closed

Forward and backward of trackpad in Webview should be disabled? #182013

yiliang114 opened this issue May 10, 2023 · 5 comments · Fixed by #184677, #187624 or #189000
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded webview Webview issues
Milestone

Comments

@yiliang114
Copy link
Contributor

yiliang114 commented May 10, 2023

Does this issue occur when all extensions are disabled?: Yes

Anywhere in the whole workspace except Webview(there may be other places), the trackpad behavior is prohibited, including forward and backward, zoom, etc, Of course the zoom behavior via (ctrl++/--) is available. But in Webview area, forward, backward and zoom of trackpad, can be used.

It's strange to be able to step back here, It is easy to misoperate. I think it should probably be disabled here.

image

  • VS Code Version: latest vscode.dev
  • OS Version: Mac os Intel

Steps to Reproduce:

  1. Open https://vscode.dev
  2. Open a remote repo or any other folder.
  3. Click a markdown file and Preview it, or any other operation that opens the webview
  4. Use backward gesture
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities webview Webview issues labels May 15, 2023
@mjbvz mjbvz added this to the Backlog milestone May 15, 2023
weartist added a commit to weartist/vscode that referenced this issue Jun 9, 2023
@weartist weartist mentioned this issue Jun 9, 2023
mjbvz pushed a commit that referenced this issue Jun 21, 2023
* Fix #182013

* 💄

* 💄
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 21, 2023
@mjbvz mjbvz modified the milestones: Backlog, June 2023 Jun 21, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 22, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 28, 2023
@TylerLeonhardt
Copy link
Member

I still repro this in insiders.vscode.dev.

@TylerLeonhardt TylerLeonhardt added the verification-found Issue verification failed label Jun 28, 2023
@alexr00 alexr00 modified the milestones: June 2023, July 2023 Jun 29, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 11, 2023

#182013 had syntax errors. Should be fixed by 6aca75d

However I'm going to also port this change to all webviews

@mjbvz mjbvz removed help wanted Issues identified as good community contribution opportunities verification-found Issue verification failed labels Jul 11, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 11, 2023
mjbvz added a commit that referenced this issue Jul 11, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 11, 2023
@yiliang114
Copy link
Contributor Author

hi @mjbvz Unfortunately, there does not seem to be a solution to this problem in insiders.vscode.dev?

image

@yiliang114
Copy link
Contributor Author

hi @mjbvz Unfortunately, there does not seem to be a solution to this problem in insiders.vscode.dev?

image

When I mentioned this a few months ago, I solved this problem in our company's internal version of vscode, but not through css attributes. If this issue will reopen, I can create another pr to try to solve this problem. @mjbvz

@rzhao271 rzhao271 added the macos Issues with VS Code on MAC/OS X label Jul 26, 2023
@roblourens
Copy link
Member

I still see this on the markdown preview

@roblourens roblourens reopened this Jul 26, 2023
@roblourens roblourens added the verification-found Issue verification failed label Jul 26, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jul 26, 2023
@mjbvz mjbvz modified the milestones: July 2023, August 2023 Jul 26, 2023
@mjbvz mjbvz removed the verification-found Issue verification failed label Jul 26, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 26, 2023
Fixes microsoft#182013

Looks like this needs to be set on the body, not the html element
mjbvz added a commit that referenced this issue Aug 9, 2023
Fixes #182013

Looks like this needs to be set on the body, not the html element
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 9, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded webview Webview issues
Projects
None yet
7 participants