Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test explorer filter UI #182648

Closed
ulugbekna opened this issue May 16, 2023 · 3 comments · Fixed by #187074 or #192017
Closed

test explorer filter UI #182648

ulugbekna opened this issue May 16, 2023 · 3 comments · Fixed by #187074 or #192017
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded

Comments

@ulugbekna
Copy link
Contributor

ulugbekna commented May 16, 2023

Two small UI issues with the filter input box in the test explorer:

  1. There's not enough right margin on the button
  2. The cursor isn't aligned to center (oh, screenshot below can't capture it but basically the cursor isn't in the center vertically of the input box).
image
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels May 16, 2023
@connor4312
Copy link
Member

Fixed in #183192

@connor4312 connor4312 added this to the June 2023 milestone Jun 8, 2023
@ulugbekna
Copy link
Contributor Author

ulugbekna commented Jun 27, 2023

Seems better but not fixed?

image

I propose that we move this to next milestone, I can take a stab at fixing this

For comparison, search input :

image

@ulugbekna ulugbekna reopened this Jun 27, 2023
@ulugbekna ulugbekna added the verification-found Issue verification failed label Jun 27, 2023
@connor4312 connor4312 modified the milestones: June 2023, July 2023 Jun 27, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 5, 2023
@ulugbekna ulugbekna removed the verification-found Issue verification failed label Jul 6, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 7, 2023
@ulugbekna
Copy link
Contributor Author

I'm sorry to do this again, but the cursor is still not centered

Screen.Recording.2023-07-25.at.15.46.42.mov

I think this is because the input widget has height of 20px

const input = this.input = this._register(this.instantiationService.createInstance(ContextScopedSuggestEnabledInputWithHistory, {

while the container has height 23

public layout(width: number) {
this.input.layout(new dom.Dimension(
width - /* horizontal padding */ 24 - /* editor padding */ 8 - /* filter button padding */ 22,
/* line height */ 27 - /* editor padding */ 4,
));
}

@ulugbekna ulugbekna reopened this Jul 26, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jul 26, 2023
@connor4312 connor4312 modified the milestones: July 2023, August 2023 Jul 26, 2023
connor4312 added a commit that referenced this issue Sep 1, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 1, 2023
@meganrogge meganrogge added the verified Verification succeeded label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
4 participants