Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should show the DiffReview by default for screen reader users when /fix is used #182789

Closed
meganrogge opened this issue May 17, 2023 · 4 comments · Fixed by #188181
Closed

We should show the DiffReview by default for screen reader users when /fix is used #182789

meganrogge opened this issue May 17, 2023 · 4 comments · Fixed by #188181
Assignees
@hediet
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2023

Comments

@meganrogge
Copy link
Contributor

meganrogge commented May 17, 2023 •
edited
Loading

ATM, users must tab into the editor and invoke f7 for a nice experience. Even if they were to do this manually, we want to prevent them from going into the underlying diff editors where the audio cues don't work and because navigation in those will be tedious.

Hack that worked to prevent tab from stopping at those editors, removed the close button which would bring the user back to them, and to focus the DiffReview, these hacks worked but aren't ideal/mergeable.

https://github.com/microsoft/vscode/compare/merogge/enter-diff-review

@jrieken had the idea that this could be accomplished by passing in original/modified ITextModel info instead of a diffEditor to the DiffReview.

It's even more hacky and not working for me, so will wait for @hediet to see if he has any other ideas

https://github.com/microsoft/vscode/compare/merogge/try-other-hack

3rd attempt, slightly less hacky but doesn't fully work because options.diffReviewOnly is always false somehow

https://github.com/microsoft/vscode/compare/merogge/3
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues polish Cleanup and polish issue labels May 17, 2023
@meganrogge meganrogge added this to the May 2023 milestone May 17, 2023
@meganrogge meganrogge mentioned this issue May 23, 2023
Closed
@meganrogge meganrogge removed their assignment May 24, 2023
@hediet hediet modified the milestones: May 2023, June 2023 May 26, 2023
@hediet hediet modified the milestones: June 2023, July 2023 Jun 27, 2023
@hediet hediet mentioned this issue Jul 5, 2023
Closed
@hediet hediet mentioned this issue Jul 18, 2023
Merged
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Introduces onlyShowAccessibleDiffViewer. Fixes #182789
8c203b5
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Introduces onlyShowAccessibleDiffViewer. Fixes #182789
6f6c8af
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Introduces onlyShowAccessibleDiffViewer. Fixes #182789
1e0a1f5
hediet added a commit that referenced this issue Jul 19, 2023
@hediet
Merge pull request #188181 from microsoft/hediet/b/experimental-sailfish
13c4597 
Introduces onlyShowAccessibleDiffViewer. Fixes #182789
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 19, 2023
@Perfecto1noly
Copy link

👌👌👍👋

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 20, 2023
@hediet hediet added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed bug Issue identified by VS Code Team member as probable bug labels Jul 21, 2023
@aiday-mar
Copy link
Contributor

Hi I was wondering what are the verification steps?

@aiday-mar aiday-mar added the verification-steps-needed Steps to verify are needed for verification label Jul 25, 2023
@hediet
Copy link
Member

hediet commented Jul 25, 2023

Just open the inline chat when screenreader mode is enabled and enter an instruction. At the moment this crashes though (#188750).

@Perfecto1noly
Copy link

Verification for this project is by authentic by Microsoft and Microsoft account through github

@meganrogge meganrogge added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2023
5 participants
@hediet @meganrogge @aiday-mar @vscodenpa @Perfecto1noly