Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting a change in diff view, inserts a debug breakpoint #183400

Closed
AbdullahAmrSobh opened this issue May 25, 2023 · 5 comments · Fixed by #184375
Closed

Reverting a change in diff view, inserts a debug breakpoint #183400

AbdullahAmrSobh opened this issue May 25, 2023 · 5 comments · Fixed by #184375
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2023

Comments

@AbdullahAmrSobh
Copy link

Does this issue occur when all extensions are disabled?: No
I can't insert debug breakpoints when extensions are disabled

  • VS Code Version: 1.78.2
  • OS Version: Win 10 x64

Steps to Reproduce:

  1. Open a diff view for any file changed in source control
  2. Click on the revert this change arrow, to revert this change

A debug break point is inserted on the same line.
@roblourens roblourens assigned joyceerhl and unassigned roblourens May 25, 2023
@gjsjohnmurray
Copy link
Contributor

Inverse of #180789

@gjsjohnmurray gjsjohnmurray mentioned this issue May 29, 2023
Closed
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Jun 6, 2023
@joyceerhl joyceerhl added this to the June 2023 milestone Jun 6, 2023
@joyceerhl joyceerhl mentioned this issue Jun 6, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 16, 2023
@jrieken jrieken added the verified Verification succeeded label Jun 28, 2023
@ulugbekna
Copy link
Contributor

ulugbekna commented Jul 2, 2023 •
edited
Loading

It seems like I can still repro:

Screen.Recording.2023-07-02.at.12.43.25.mov

(Line number being relative is not relevant)

version info:

Version: 1.80.0-insider
Commit: 39efe30bfc8e196f5be2119479092bd9eb83e174
Date: 2023-06-30T14:59:08.350Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.5.0

@ulugbekna ulugbekna reopened this Jul 2, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jul 2, 2023
@ulugbekna ulugbekna added verification-found Issue verification failed and removed verified Verification succeeded labels Jul 2, 2023
@joyceerhl joyceerhl modified the milestones: June 2023, July 2023 Jul 3, 2023
@joyceerhl joyceerhl removed the verification-found Issue verification failed label Jul 3, 2023
@bmadone
Copy link

bmadone commented Jul 21, 2023

Any updates?

@joyceerhl joyceerhl modified the milestones: July 2023, August 2023 Jul 27, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Jul 27, 2023
Closed
This was referenced Aug 4, 2023
Closed
Closed
@joyceerhl joyceerhl modified the milestones: August 2023, September 2023 Aug 28, 2023
@joyceerhl joyceerhl removed this from the September 2023 milestone Sep 27, 2023
@joyceerhl joyceerhl added this to the October 2023 milestone Sep 27, 2023
@daviddq
Copy link

daviddq commented Sep 29, 2023

Hi! Any updates on this issue? Any temporary workaround? Thanks :)

@joyceerhl joyceerhl modified the milestones: October 2023, November 2023 Oct 26, 2023
@joyceerhl joyceerhl assigned hediet and unassigned joyceerhl Nov 29, 2023
@joyceerhl
Copy link
Contributor

\closedWith 9ed6654

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 29, 2023
@jrieken jrieken added the verified Verification succeeded label Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

Implement GlyphMarginWidgets microsoft/vscode
10 participants
@roblourens @jrieken @hediet @daviddq @gjsjohnmurray @AbdullahAmrSobh @ulugbekna @bmadone @joyceerhl @VSCodeTriageBot