Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new tab sizing option fixed #183532

Closed
2 tasks done
bpasero opened this issue May 26, 2023 · 3 comments
Closed
2 tasks done

Test new tab sizing option fixed #183532

bpasero opened this issue May 26, 2023 · 3 comments

Comments

@bpasero
Copy link
Member

bpasero commented May 26, 2023

Refs: #40290

Complexity: 3

Create Issue


Make sure to have editor tabs enabled and configure workbench.editor.tabSizing to the new option fixed. This new option will ensure that each tab gets the same width and further makes it easy to rapidly close tabs using the mouse by keeping the sizes of the tabs stable until the mouse moves out:

Recording 2023-05-26 at 15 04 38

Testing

  • all tabs have an even width up to a minimum and then a scrollbar appears
  • the initial tab width can be configured with the new workbench.editor.tabSizingFixedMaxWidth setting
  • move tabs around, open new ones and close them and verify things work in one or many editor groups
  • pin some tabs (from the context menu) and verify things still work as before
  • play around with various tab settings and verify nothing breaks or looses functionality
    • workbench.editor.tabCloseButton: set to left or off
    • workbench.editor.showIcons: set to false
    • workbench.editor.pinnedTabSizing: set to compact or shrink with pinned tabs
    • workbench.editor.wrapTabs: set to true and having many tabs open so that they wrap
  • there should never be any screen 🧀
@bpasero bpasero added this to the May 2023 milestone May 26, 2023
@ghost ghost assigned deepak1556 and karthiknadig May 30, 2023
@deepak1556
Copy link
Collaborator

and then a scrollbar appears

Can you clarify where the scrollbar should be seen ?

@bpasero
Copy link
Member Author

bpasero commented May 30, 2023

@deepak1556 a horizontal scrollbar below the tab stripe when the available width is not enough to fit all tabs. it only appears when you hover over.

@kpatelPro
Copy link

Would love workbench.editor.tabSizingFixedMinWidth. At present tabs will shrink much more than I would ever like... down to where I can only read ~5 characters of the name of a file in the tab.

Could also be implemented as generic workbench.editor.tabSizingMinWidth, and be used by both tabSizing:fixed and to specify the desired width for tabSizing:shrink

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants