Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: share provider proposed API #183574

Closed
3 tasks done
joyceerhl opened this issue May 26, 2023 · 0 comments
Closed
3 tasks done

Test: share provider proposed API #183574

joyceerhl opened this issue May 26, 2023 · 0 comments

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented May 26, 2023

Refs: #176316

Complexity: 5
Roles: Developer, Engineering Manager

Create Issue


Background

We're exploring a share provider API to support sharing actions built into core. This API is not for finalization this milestone.

Currently this is integrated primarily through:

  1. the new Share... command in the command palette
  2. a Share... button that is positioned next to the command center when "window.commandCenter": true and "workbench.experimental.share.enabled": true (the latter setting is currently not advertised in settings UI)

Eventually we will also leverage this API for surfacing Share in other areas such as context menus in the editor and tree views.

Testing

Please try out this provider API in an extension:

https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.proposed.shareProvider.d.ts

Please verify that:

  • Your specified sort order is respected WRT other available options
  • The document selector is respected when deciding whether to show a provider as an option for a resource URI
  • The current API and docstrings make sense

Known issues:

  • There is no onShare event yet because all extensions which want to adopt it are already onStartupFinished or onFileSystem activated
  • Do not test the TreeItem.shareableItem part of the proposal; that isn't being used in core yet
@joyceerhl joyceerhl added this to the May 2023 milestone May 26, 2023
@ghost ghost assigned ulugbekna and Yoyokrazy May 30, 2023
@ulugbekna ulugbekna removed their assignment May 30, 2023
@aiday-mar aiday-mar removed their assignment May 31, 2023
@Yoyokrazy Yoyokrazy removed their assignment May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants