Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share provider doesn't receive selection #183810

Closed
ulugbekna opened this issue May 30, 2023 · 0 comments · Fixed by #184196
Closed

Share provider doesn't receive selection #183810

ulugbekna opened this issue May 30, 2023 · 0 comments · Fixed by #184196
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@ulugbekna
Copy link
Contributor

Testing #183574

My extension's provider is not receiving the selection within the ShareableItem passed to its provideShare

I think this's caused by this -

const uri = await shareService.provideShare({ resourceUri }, new CancellationTokenSource().token);

@joyceerhl joyceerhl added the feature-request Request for new features or functionality label May 31, 2023
@joyceerhl joyceerhl added this to the June 2023 milestone May 31, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants