Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: improvements to sharing links #186199

Closed
2 tasks done
joyceerhl opened this issue Jun 26, 2023 · 2 comments
Closed
2 tasks done

Test: improvements to sharing links #186199

joyceerhl opened this issue Jun 26, 2023 · 2 comments

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jun 26, 2023

Refs: #176316, #183810, #185908

Complexity: 5

Create Issue


We've made further improvements to copying and sharing links from inside VS Code.

Test:

  1. Open an Azure Repos repository in insiders.vscode.dev. Right click in the editor gutter and Copy vscode.dev Link for a line. Paste the link into your browser tab and verify that it takes you back to that specific line for Azure Repos
  2. Open a GitHub repository that has been cloned with git to your local machine. Be on an unpublished branch. Right click in the editor gutter and Copy vscode.dev Link for a line. Verify that you are informed the branch is not yet published to the remote, and that the followup actions work and make sense.
  3. Repeat step 2 for the following scenarios:
    • Have some local uncommitted changes (either staged or in working tree)
    • Be a couple of commits behind the remote
  4. Enable window.commandCenter and workbench.experimental.share.enabled, reload window, and install GitHub Pull Requests and Issues pre-release
    • Ensure a Copy Markdown Link option is available from the share button next to the command center and that it works as expected
    • If you have an active editor selection, ensure that all the options from the share button include a deeplink to the editor selection
@lszomoru
Copy link
Member

Ensure a Copy Markdown Link option is available from the share button next to the command center and that it works as expected

Do you mean "Copy GitHub Permalink as Markdown"?

Image

@Yoyokrazy
Copy link
Contributor

Also running into #186298, and same expectation for uncommitted changes, expected a dialog.

@Yoyokrazy Yoyokrazy removed their assignment Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants