Unify remote menu and start entry items for desktop #185908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
reviewed
Jun 22, 2023
joyceerhl
reviewed
Jun 22, 2023
joyceerhl
reviewed
Jun 22, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #184845
Changes:
remoteIndicator.ts - Moved code over from
remoteStartEntry.tsfor displaying and installing installable extensions in the remote menu quick pick.remoteStartEntry.ts - Removed all code related to fetching remote commands. We now rely entirely on the remote menu for this. Only code remaining in the remote start entry is the code to execute start command for tunnel since the welcome page for the web contains a
Connect to tunnelentry instead.Continue onmenu items now also show up in the remote start entrygettingStartedContent.ts - switch over to using the
remote.showMenucommand.