Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing links - commits behind remote #186298

Closed
lszomoru opened this issue Jun 27, 2023 · 2 comments · Fixed by #186576
Closed

Sharing links - commits behind remote #186298

lszomoru opened this issue Jun 27, 2023 · 2 comments · Fixed by #186576
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Testing #186199

I am currently one commit behind the remote branch and I am able to successfully create a link without seeing any dialog. The way the test plan item is written it implies that in this scenario, I should see a dialog. Is that the case or did I misunderstood the test plan item?

@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2023
@joyceerhl joyceerhl added this to the June 2023 milestone Jun 27, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@chrmarti
Copy link
Contributor

Testing with Copy vscode.dev Link while being a few commits behind, I get the following dialog:
image

When I Cancel, I don't get a link. When I Pull & Copy I get a link that is seemingly unaffected by the pull. Why then require the pull? (I tested with incoming commits affecting the file I copy a link from.)

@chrmarti chrmarti added the verified Verification succeeded label Jun 29, 2023
@joyceerhl
Copy link
Contributor

The link that is copied might point to a range that is invalidated by incoming commits, so we notify in order to avoid you copying a link that points to a different area in the file. But perhaps we should also offer a Copy Anyway option here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants