Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing links - publish branch & copy link #186293

Closed
lszomoru opened this issue Jun 27, 2023 · 0 comments · Fixed by #186576
Closed

Sharing links - publish branch & copy link #186293

lszomoru opened this issue Jun 27, 2023 · 0 comments · Fixed by #186576
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 27, 2023

Testing #186199

When one tries to copy a link on a branch that has not been published we display a dialog asking the user whether they want to publish the branch. Based on my tests, the branch is getting published and the linked is being copied to the clipboard. I think that it makes sense to be explicit about what happens and change the label of the button to "Publish Branch & Copy Link".

I also noticed that when trying to create a link for uncommited changes, the dialog contains an action to "Copy Anyways". I think actions should be consistent so we should add that action to this dialog as well.

@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2023
@joyceerhl joyceerhl added this to the June 2023 milestone Jun 27, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@chrmarti chrmarti added the verified Verification succeeded label Jun 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants