Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tunnel service log should contain information when the service was stopped #183696

Closed
aeschli opened this issue May 29, 2023 · 0 comments · Fixed by #185385
Closed

Tunnel service log should contain information when the service was stopped #183696

aeschli opened this issue May 29, 2023 · 0 comments · Fixed by #185385
Assignees
@connor4312
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders remote-tunnel verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented May 29, 2023

Version: 1.79.0-insider (user setup)
Commit: 2dfb838
Date: 2023-05-26T05:22:45.569Z
Electron: 22.5.3
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.22624

The service log file should contain information (timestamp) when the service was stopped and started.

  • run a sequence of code-insiders tunnel service install and run code-insiders tunnel service uninstall (as VS Code update would do)
  • look at the log with code-insiders tunnel service log.
    • it doesn't contain information the service was stopped (appears to be running)
    • It only contains the information on the last session. Would be great if it could have the history of when the service was previously started/stopped
@aeschli aeschli changed the title Tunnel service log should contain information when the service was stopped go sessions and contain information when service was started and stopped Tunnel service log should contain information when the service was stopped May 29, 2023
@aeschli aeschli added remote-tunnel feature-request Request for new features or functionality labels May 29, 2023
@connor4312 connor4312 mentioned this issue Jun 9, 2023
Closed
connor4312 added a commit that referenced this issue Jun 16, 2023
@connor4312
cli: log startup and shutdown, don't clear service logs on restart
95e90d2 
Fixes #183696
@connor4312 connor4312 mentioned this issue Jun 16, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 16, 2023
@vscodenpa vscodenpa added this to the June 2023 milestone Jun 16, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 19, 2023
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jun 27, 2023
@hediet hediet added the verified Verification succeeded label Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders remote-tunnel verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

Cli service improvements microsoft/vscode
4 participants
@connor4312 @hediet @aeschli @vscodenpa