Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create xterm.js log channel #185349

Closed
Tyriar opened this issue Jun 16, 2023 · 1 comment · Fixed by #185358
Closed

Create xterm.js log channel #185349

Tyriar opened this issue Jun 16, 2023 · 1 comment · Fixed by #185358
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
June 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2023

Upstream PR to enable this: xtermjs/xterm.js#4563
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Jun 16, 2023
@Tyriar Tyriar added this to the June 2023 milestone Jun 16, 2023
@Tyriar Tyriar self-assigned this Jun 16, 2023
Tyriar added a commit that referenced this issue Jun 16, 2023
@Tyriar
Replace escape sequence logging with terminal log channel
6287e1f 
Fixes #185349
@Tyriar Tyriar mentioned this issue Jun 16, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 16, 2023
@VMS1987
Copy link

VMS1987 commented Jun 23, 2023

Grant him the merge

@Tyriar Tyriar added the verified Verification succeeded label Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

Replace escape sequence logging with terminal log channel microsoft/vscode
3 participants
@Tyriar @vscodenpa @VMS1987