-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readonly hover seems to disappear slightly too fast #186257
Comments
👍 felt the same, I think using the workbench hover infra would help. |
I think given the new complexity of this hover and the actions we should do a tactical fix here. I suggest to remove the timer that removes the message automatically after 3 seconds: vscode/src/vs/editor/contrib/message/browser/messageController.ts Lines 92 to 93 in ac34ea3
There are still other listeners in place to hide the message, so I think we are good. |
👍 makes sense. |
trying to verify: "readonly hover" means "hover in readonly files" ? |
@ulugbekna best to verify would be in |
Testing #186170
Tiniest of nits, and perhaps this is inherited from all hovers, but I felt like the hover disappeared too quickly. If I was reading particularly slowly or looked away and then back at the message, I might've missed it.
The text was updated successfully, but these errors were encountered: