Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly hover seems to disappear slightly too fast #186257

Closed
daviddossett opened this issue Jun 27, 2023 · 6 comments · Fixed by #186480
Closed

Readonly hover seems to disappear slightly too fast #186257

daviddossett opened this issue Jun 27, 2023 · 6 comments · Fixed by #186480
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@daviddossett
Copy link
Contributor

Testing #186170

Tiniest of nits, and perhaps this is inherited from all hovers, but I felt like the hover disappeared too quickly. If I was reading particularly slowly or looked away and then back at the message, I might've missed it.

@bpasero
Copy link
Member

bpasero commented Jun 27, 2023

👍 felt the same, I think using the workbench hover infra would help.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2023
@alexr00 alexr00 added this to the Backlog milestone Jun 27, 2023
@bpasero bpasero modified the milestones: Backlog, On Deck Jun 27, 2023
@hediet
Copy link
Member

hediet commented Jun 27, 2023

Also, it disappears when you still hover on it:

Code_-_Insiders_CYA8RjUh6T

@bpasero bpasero modified the milestones: On Deck, June 2023 Jun 27, 2023
@bpasero
Copy link
Member

bpasero commented Jun 27, 2023

I think given the new complexity of this hover and the actions we should do a tactical fix here. I suggest to remove the timer that removes the message automatically after 3 seconds:

// 3sec
this._messageListeners.add(new TimeoutTimer(() => this.closeMessage(), 3000));

There are still other listeners in place to hide the message, so I think we are good.

@alexr00
Copy link
Member

alexr00 commented Jun 27, 2023

👍 makes sense.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@ulugbekna
Copy link
Contributor

trying to verify: "readonly hover" means "hover in readonly files" ?

@bpasero
Copy link
Member

bpasero commented Jun 29, 2023

@ulugbekna best to verify would be in vscode repo open a file from node_modules folder and try to edit in such a file. You should see a hover with a link.

@ulugbekna ulugbekna added the verified Verification succeeded label Jun 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants