editor - update style and behaviour of message widget #186480
Conversation
| this.closeMessage(); | ||
| // close on blur (debounced to allow to tab into the message), cursor, model change, dispose | ||
| this._messageListeners.add(Event.debounce(this._editor.onDidBlurEditorText, (last, event) => event, 0)(() => { | ||
| if (this._mouseOverMessage) { |
There was a problem hiding this comment.
I believe you could get away without this property and check. The editor can tell you if it has text or widget focus and because the message is content widget focusing it will mean the editor signals widget focus (hasWidgetFocus)
There was a problem hiding this comment.
Yeah, I think my intent is to preserve as much of the behaviour today, where the message widget should not remain visible too much, but the only exception is when focus goes into the message widget, specifically when there is a link and you tab into the message to execute it:
Since the event order without debouncing will be that blur is emitted first, we would otherwise eagerly close the message widget, even though it is in the process of receiving focus.
fix #186256
fix #186257