Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test output - resizing panel cases content to jump up/down #186328

Closed
lszomoru opened this issue Jun 27, 2023 · 5 comments
Closed

Test output - resizing panel cases content to jump up/down #186328

lszomoru opened this issue Jun 27, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal-rendering

Comments

@lszomoru
Copy link
Member

Testing #186245

Screen.Recording.2023-06-27.at.13.42.17.mov
@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2023

@connor4312 not sure about the flickering, but you'll want to debounce resize in a similar way to the terminal:

@debounce(50)
private async _resize(): Promise<void> {
this._resizeNow(false);
}

@Tyriar Tyriar removed their assignment Jun 27, 2023
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue testing Built-in testing support labels Jun 27, 2023
@connor4312
Copy link
Member

connor4312 commented Jul 5, 2023

I also don't get the flickering. Looks like it may have something to do with word wrapping in the terminal. @lszomoru what font do you use in the terminal?

I will debounce the resize in my side, which I think will also fix flickering in this case, but will leave this issue open in case you want to look into it more on the terminal side.

@connor4312 connor4312 assigned Tyriar and unassigned connor4312 Jul 5, 2023
@connor4312 connor4312 removed polish Cleanup and polish issue testing Built-in testing support labels Jul 5, 2023
connor4312 added a commit that referenced this issue Jul 5, 2023
@lszomoru
Copy link
Member Author

Image

@joyceerhl
Copy link
Collaborator

With FiraCode NF and running this test https://github.com/microsoft/vscode/blob/d2bc579ada1b1974d87da453a798f07bdf13a1d7/src/vs/base/test/common/arrays.test.ts resizing the results panel doesn't cause content to jump up and down. @lszomoru is this still reproducible for you?

@joyceerhl joyceerhl added info-needed Issue requires more information from poster terminal-rendering labels Dec 15, 2023
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal-rendering
Projects
None yet
Development

No branches or pull requests

6 participants