Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline output action not disposed when test changes #186372

Closed
joyceerhl opened this issue Jun 27, 2023 · 1 comment · Fixed by #186379
Closed

Inline output action not disposed when test changes #186372

joyceerhl opened this issue Jun 27, 2023 · 1 comment · Fixed by #186379
Assignees
@connor4312
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
June 2023

Comments

@joyceerhl
Copy link
Contributor

Testing #186245

  1. Add a console.log
  2. Run the test
  3. Take out the console.log
  4. Run the test
  5. 🐛 inline action is still there
image
@connor4312
Copy link
Member

This was an opt-in setting, but it should not have been on by default

@connor4312 connor4312 mentioned this issue Jun 27, 2023
Merged
connor4312 added a commit that referenced this issue Jun 27, 2023
@connor4312
testing: don't enable showAllMessages by default
0a28d2d 
Fixes #186372
@Tyriar Tyriar removed their assignment Jun 27, 2023
connor4312 added a commit that referenced this issue Jun 27, 2023
@connor4312
testing: don't enable showAllMessages by default (#186379)
56ec765 
Fixes #186372
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 27, 2023
@vscodenpa vscodenpa added this to the June 2023 milestone Jun 27, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

testing: don't enable showAllMessages by default microsoft/vscode
4 participants
@Tyriar @connor4312 @joyceerhl @vscodenpa