Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent test status between peek view and test results panel #186376

Closed
joyceerhl opened this issue Jun 27, 2023 · 0 comments · Fixed by #186802
Closed

Inconsistent test status between peek view and test results panel #186376

joyceerhl opened this issue Jun 27, 2023 · 0 comments · Fixed by #186802
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
July 2023

Comments

@joyceerhl
Copy link
Contributor

Testing #186245

  1. Make an async test fail
  2. 🐛 Test appears to still be running in the peek view but has decisively failed in the panel view
image
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jun 27, 2023
@connor4312 connor4312 mentioned this issue Jun 30, 2023
Merged
connor4312 added a commit that referenced this issue Jun 30, 2023
@connor4312
testing: fix state not updating when failing peek opens
b1028c4 
Fixes #186376
connor4312 added a commit that referenced this issue Jun 30, 2023
@connor4312
testing: fix state not updating when failing peek opens (#186802)
de68ea3 
* testing: improve performance when ending test with large number of results

Takes `markTaskComplete` 11,200ms to 70ms when running a 10k test suite,
by maintaining a count of computed states for children and avoiding
refreshing nodes unnecessarily.

For microsoft/vscode-python#21507

* testing: fix state not updating when failing peek opens

Fixes #186376
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 30, 2023
@vscodenpa vscodenpa added this to the July 2023 milestone Jun 30, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 7, 2023
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

testing: fix state not updating when failing peek opens microsoft/vscode
5 participants
@DonJayamanne @Tyriar @connor4312 @joyceerhl @vscodenpa