"Collapse unchanged regions" looks disabled

[roblourens]

Testing #186213

Should use a toggle state instead, or a new icon. You can see it looks the same as the other disabled action

[hediet]

I agree, but then this also applies to the "toggle whitespace" button.

I think we need some pressed state for toolbar buttons.
What are your thoughts @jrieken @hbons ?

[jrieken]

I'd prefer to have an icon per state. That's how we have done it in other toolbars (like output scroll lock).

[hbons]

Mockup with a toggled state.

Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though.

cc @daviddossett

[daviddossett]

We do use toggles elsewhere. One easy example:

But I think it depends what you're trying to do. Many boolean settings make sense as a sort of enabled/disabled toggle, while others are more specific metaphors (lock/unlock as Hylke mentioned above).

[hediet]

I'm still in favor of a toggle border as we already use this concept in the find widget and it is a universally understood concept, but @jrieken has to agree.
Alternatively, we can explore other icons.
Or we leave it as is.

[jrieken]

No, I don't need to agree (but also not to like it). If you wanna explore #186403 (comment) or something similar go ahead but we should be aware that this is also open to extensions, so we need to deal with every (contributed) button looking like this in the future

[abhijit-chikane]

Mockup with a toggled state.

Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though.

cc @daviddossett

I think this approach looks good to me
It is more aligned with the vs code current design and should be replaced the current find widget toggle ui

[hediet]

Verification steps:

• Notice that in the diff editor buttons have a background now to indicate their toggled state: