Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore showing workspace search results in the command center #189964

Closed
andreamah opened this issue Aug 8, 2023 · 4 comments
Closed

Explore showing workspace search results in the command center #189964

andreamah opened this issue Aug 8, 2023 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues
Milestone

Comments

@andreamah
Copy link
Contributor

We want to start to explore what it'd be like to have a quickpick that shows text results.

For example, if we search activate in the vscode-livepreview repo, we don't get anything because it isn't in any filenames.

Image

It would be nice if vscode knew that activate was in the extension.ts file and showed that file.

Image

@andreamah andreamah added feature-request Request for new features or functionality search Search widget and operation issues labels Aug 8, 2023
@andreamah andreamah added this to the August 2023 milestone Aug 8, 2023
@andreamah andreamah self-assigned this Aug 8, 2023
@gjsjohnmurray
Copy link
Contributor

I started trying this our in Insiders. Initially didn't seem to work, until I realized it's vital to enter a space after the % character prefix.

@andreamah
Copy link
Contributor Author

andreamah commented Aug 23, 2023

The reason why we need a space after the % is because we try to keep the same pattern as the other quick accesses
image

Edit: I just remembered that symbols like the command palette > don't automatically add a space. I was originally basing mine based on ones like debug where it'd make sense to have a space. I'll reconsider removing the space...

@gjsjohnmurray
Copy link
Contributor

One argument for requiring a space is if the workspace has files whose names begin with %

@andreamah
Copy link
Contributor Author

We now have a preliminary version of this. I will close this and additional requests regarding it can be in its own issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants